Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow custom boot/connect timeouts for testcloud VMs #2677

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Allow custom boot/connect timeouts for testcloud VMs #2677

merged 1 commit into from
Feb 15, 2024

Conversation

happz
Copy link
Collaborator

@happz happz commented Feb 9, 2024

Pull Request Checklist

  • implement the feature
  • write the documentation

@happz happz added this to the 1.32 milestone Feb 9, 2024
@happz happz mentioned this pull request Feb 9, 2024
Merged
1 task
@happz
Copy link
Collaborator Author

happz commented Feb 9, 2024

/packit test

@lukaszachy lukaszachy force-pushed the testcloud-control-boot-connect-timeouts branch from 1d1e900 to 9f2e070 Compare February 9, 2024 14:34
@happz
Copy link
Collaborator Author

happz commented Feb 9, 2024

/packit test

@happz happz force-pushed the testcloud-control-boot-connect-timeouts branch from 9f2e070 to dd43fba Compare February 12, 2024 12:08
@lukaszachy
Copy link
Collaborator

Shouldn't we add __versionadded label?

@happz
Copy link
Collaborator Author

happz commented Feb 12, 2024

Shouldn't we add __versionadded label?

Added in ebed80d

@happz
Copy link
Collaborator Author

happz commented Feb 13, 2024

/packit test

1 similar comment
@happz
Copy link
Collaborator Author

happz commented Feb 13, 2024

/packit test

@happz
Copy link
Collaborator Author

happz commented Feb 13, 2024

I'm looking for inputs from @frantisekz, the failure of parallel test stinks with race conditions :/

psss
psss requested changes Feb 14, 2024
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just two suggestions.

docs/overview.rst Outdated Show resolved Hide resolved
tmt/steps/provision/__init__.py Outdated Show resolved Hide resolved
@happz happz force-pushed the testcloud-control-boot-connect-timeouts branch from 01b9a8a to 00b8b8d Compare February 15, 2024 08:31
psss
psss requested changes Feb 15, 2024
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just two questions.

tmt/utils.py Outdated Show resolved Hide resolved
tmt/utils.py Outdated Show resolved Hide resolved
@psss psss added step | provision Stuff related to the provision step plugin | testcloud The testcloud virtual provision plugin labels Feb 15, 2024
psss
psss approved these changes Feb 15, 2024
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this improvement!

@psss psss self-assigned this Feb 15, 2024
@psss psss added the ci | full test Pull request is ready for the full test execution label Feb 15, 2024
@psss psss force-pushed the testcloud-control-boot-connect-timeouts branch from 297b643 to 846e2a7 Compare February 15, 2024 11:38
@psss psss mentioned this pull request Feb 15, 2024
Closed
@psss
Copy link
Collaborator

psss commented Feb 15, 2024

I'm looking for inputs from @frantisekz, the failure of parallel test stinks with race conditions :/

Yeah, looks like that. Filed #2687 to track this. Everything else passed, let's not block the PR on this.

@psss psss merged commit 846e2a7 into main Feb 15, 2024
19 of 22 checks passed
@psss psss deleted the testcloud-control-boot-connect-timeouts branch February 15, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frantisekz frantisekz frantisekz approved these changes

@lukaszachy lukaszachy lukaszachy approved these changes

@psss psss psss approved these changes

@thrix thrix Awaiting requested review from thrix thrix is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

Assignees

@psss psss

Labels
ci | full test Pull request is ready for the full test execution plugin | testcloud The testcloud virtual provision plugin step | provision Stuff related to the provision step
Projects
None yet
Milestone
1.32
Development

Successfully merging this pull request may close these issues.
4 participants
@happz @lukaszachy @psss @frantisekz