Add essential requirements to checks

tmt/checks/__init__.py

@@ -18,6 +18,7 @@
  import tmt.base
  from tmt.result import CheckResult
  from tmt.steps.execute import TestInvocation
+ from tmt.steps.provision import Guest
 
 
 #: A type variable representing a :py:class:`Check` instances.
@@ -180,6 +181,23 @@ def delegate(
  return cast(CheckPlugin[CheckT], find_plugin(raw_data['how'])) \
  ._check_class.from_spec(raw_data, logger)
 
+ @classmethod
+ def essential_requires(
+ cls,
+ guest: 'Guest',
+ test: 'tmt.base.Test',
+ logger: tmt.log.Logger) -> list['tmt.base.DependencySimple']:
+ """
+ Collect all essential requirements of the test check.
+
+ Essential requirements of a check are necessary for the check to
+ perform its basic functionality.
+
+ :returns: a list of requirements.
+ """
+
+ return []
+
  @classmethod
  def before_test(
  cls,

tmt/checks/avc.py

@@ -11,7 +11,9 @@
 from tmt.utils import CommandOutput, Path, ShellScript, render_run_exception_streams
 
 if TYPE_CHECKING:
+ import tmt.base
  from tmt.steps.execute import TestInvocation
+ from tmt.steps.provision import Guest
 
 #: The filename of the final check report file.
 TEST_POST_AVC_FILENAME = 'avc.txt'
@@ -285,6 +287,23 @@ class AvcDenials(CheckPlugin[Check]):
 
  _check_class = Check
 
+ @classmethod
+ def essential_requires(
+ cls,
+ guest: 'Guest',
+ test: 'tmt.base.Test',
+ logger: tmt.log.Logger) -> list['tmt.base.DependencySimple']:
+ if not guest.facts.has_selinux:
+ return []
+
+ # Avoid circular imports
+ import tmt.base
+
+ return [
+ tmt.base.DependencySimple('/usr/bin/sestatus'),
+ tmt.base.DependencySimple('/usr/sbin/ausearch')
+ ]
+
  @classmethod
  def before_test(
  cls,

tmt/checks/dmesg.py

@@ -12,7 +12,9 @@
 from tmt.utils import Path, render_run_exception_streams
 
 if TYPE_CHECKING:
+ import tmt.base
  from tmt.steps.execute import TestInvocation
+ from tmt.steps.provision import Guest
 
 TEST_POST_DMESG_FILENAME = 'dmesg-{event}.txt'
 FAILURE_PATTERNS = [
@@ -42,6 +44,20 @@ class DmesgCheck(CheckPlugin[Check]):
 
  _check_class = Check
 
+ @classmethod
+ def essential_requires(
+ cls,
+ guest: 'Guest',
+ test: 'tmt.base.Test',
+ logger: tmt.log.Logger) -> list['tmt.base.DependencySimple']:
+ if not guest.facts.has_capability(GuestCapability.SYSLOG_ACTION_READ_ALL):
+ return []
+
+ # Avoid circular imports
+ import tmt.base
+
+ return [tmt.base.DependencySimple('/usr/bin/dmesg')]
+
  @classmethod
  def _fetch_dmesg(
  cls,

tmt/steps/prepare/__init__.py

@@ -261,6 +261,12 @@ def as_key(self) -> frozenset['tmt.base.DependencySimple']:
  test,
  self._logger)
 
+ for check in test.check:
+ collected_requires[guest].dependencies += check.plugin.essential_requires(
+ guest,
+ test,
+ self._logger)
+
  # Now we have guests and all their requirements. There can be
  # duplicities, multiple tests requesting the same package, but also
  # some guests may share the set of packages to be installed on them.