Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the reportportal plugin #2702

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Update the reportportal plugin #2702

merged 1 commit into from
Mar 26, 2024

Conversation

4N0body5
Copy link
Collaborator

@4N0body5 4N0body5 commented Feb 22, 2024 •
edited by psss
Loading

Features:

  • support of environment variables TMT_PLUGIN_REPORT_REPORTPORTAL_<option> also for report step set via fmf
  • launch-description option modified to append an existing description instead of overwriting it
  • option to specify api-version

Pull Request Checklist

  • implement the feature
  • write the documentation
  • modify the json schema

Plan for additional PR:

  • rerun of failed report for older ReportPortal version
  • test coverage

@4N0body5 4N0body5 added step | report Stuff related to the report step plugin | reportportal The reportportal report plugin labels Feb 26, 2024
@4N0body5 4N0body5 requested a review from happz February 26, 2024 22:16
@4N0body5 4N0body5 requested a review from happz February 27, 2024 09:20
@psss
Copy link
Collaborator

psss commented Mar 6, 2024 •
edited
Loading

This is an important blocker for compose qualification testing, proposing for 1.32.

@psss psss added this to the 1.32 milestone Mar 6, 2024
@4N0body5 4N0body5 requested a review from happz March 18, 2024 13:05
psss
psss requested changes Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving this, looks good. Added just a few minor comments.

tmt/steps/report/reportportal.py Show resolved Hide resolved
tmt/steps/report/reportportal.py Outdated Show resolved Hide resolved
tmt/steps/report/reportportal.py Outdated Show resolved Hide resolved
tmt/steps/report/reportportal.py Show resolved Hide resolved
@4N0body5 @psss
Update the reportportal plugin
ae19b2d 
- manual addition of environment variables for options (for report
  step via fmf)
- modified launch-description option to append an existing
  description instead of overwriting
@psss psss changed the title Update ReportPortal Plugin Extension Update the reportportal plugin Mar 25, 2024
psss
psss approved these changes Mar 25, 2024
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving this!

@psss psss added the ci | full test Pull request is ready for the full test execution label Mar 25, 2024
@psss
Copy link
Collaborator

psss commented Mar 25, 2024

/packit test

@psss psss self-assigned this Mar 26, 2024
@psss psss merged commit ae19b2d into main Mar 26, 2024
19 of 20 checks passed
@psss psss deleted the reportportalAPI branch March 26, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psss psss psss approved these changes

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@thrix thrix Awaiting requested review from thrix thrix is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

@happz happz Awaiting requested review from happz happz is a code owner

Assignees

@psss psss

Labels
ci | full test Pull request is ready for the full test execution plugin | reportportal The reportportal report plugin step | report Stuff related to the report step
Projects
None yet
Milestone
1.32
Development

Successfully merging this pull request may close these issues.
3 participants
@4N0body5 @psss @happz