Add support for disk.model-name hardware requirement
#2708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skycastlelily
requested review from
psss,
lukaszachy,
happz,
thrix and
janhavlin
as code owners
happz
reviewed
Feb 23, 2024
happz
added
specification
|
updated^^
…On Fri, Feb 23, 2024 at 4:26 PM Miloš Prchlík ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In spec/hardware/disk.fmf
<#2708 (comment)>:
> @@ -9,20 +9,29 @@ description: |
# Number or string, the amount of storage requested.
# Bytes are assumed when no unit is specified.
- size: 1234|">= 512 GiB"
+ # String, disk model requested.
+ - model-name: "well-known disk model"
versionchanged should be here, see e.g.
https:/teemtee/tmt/blob/main/spec/hardware/network.fmf#L27:
.. versionchanged:: 1.32
Added `model-name` into specification.
—
Reply to this email directly, view it on GitHub
<#2708 (review)>,
or unsubscribe
<https:/notifications/unsubscribe-auth/AKFR23COLVPXDICNDIS7YZTYVBHCZAVCNFSM6AAAAABDWB6JZOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQOJXGU4TENJRGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
psss
changed the title
disk.model hardware requirement
psss
approved these changes
Feb 27, 2024
|
Updated accordingly:)
…On Tue, Feb 27, 2024 at 10:09 PM Petr Šplíchal ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In spec/hardware/disk.fmf
<#2708 (comment)>:
>
link:
+ - #2705
+ - https://gitlab.com/testing-farm/artemis/-/merge_requests/1195
Ack, sounds good.
—
Reply to this email directly, view it on GitHub
<#2708 (comment)>, or
unsubscribe
<https:/notifications/unsubscribe-auth/AKFR23AUZZMGGXLVTAC6QF3YVXSHXAVCNFSM6AAAAABDWB6JZOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMBTGYYTINRQGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Please, mention |
|
Er,really sorry😅,updated,should be good now.
…On Tue, Feb 27, 2024 at 10:53 PM Petr Šplíchal ***@***.***> wrote:
Updated accordingly:)
Please, mention size in the testcloud note as well. And let's remove the
pull/merge requests link.
—
Reply to this email directly, view it on GitHub
<#2708 (comment)>, or
unsubscribe
<https:/notifications/unsubscribe-auth/AKFR23DM5OFEG7XRHUEZP7LYVXXM3AVCNFSM6AAAAABDWB6JZOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRWG4ZDOMBYG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Yeah, now looks good, thanks! |
|
Just went through the pull request checklist (it's useful isn't it? ;-) and realized that it would be good to mention the new key in the releases notes. Should be covered by 69d926a. |
psss
changed the title
disk.model hardware requirementdisk.model-name hardware requirement
|
Yes,thanks:)
…On Tue, Feb 27, 2024 at 11:41 PM Petr Šplíchal ***@***.***> wrote:
Just went through the pull request checklist (it's useful isn't it? ;-)
and realized that it would be good to mention the new key in the releases
notes. Should be covered by 69d926a
<69d926a>
.
—
Reply to this email directly, view it on GitHub
<#2708 (comment)>, or
unsubscribe
<https:/notifications/unsubscribe-auth/AKFR23FPZTGAJ6RJTZM77LDYVX5BRAVCNFSM6AAAAABDWB6JZOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRWHA2DONBSG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
/packit test |
|
/packit test |
happz
approved these changes
Feb 28, 2024
|
Test failures are irrelevant, timeout should be fixed by #2718. |
|
Thanks:)
…On Wed, Feb 28, 2024 at 5:58 PM Petr Šplíchal ***@***.***> wrote:
Merged #2708 <#2708> into main.
—
Reply to this email directly, view it on GitHub
<#2708 (comment)>, or
unsubscribe
<https:/notifications/unsubscribe-auth/AKFR23GERWSK56Z4VCLTKTTYV35VLAVCNFSM6AAAAABDWB6JZOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRHE2DSMRQHE2DSMA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist