Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix /plans/provision/virtual to set correct PROVISION_* variable #2722

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Fix /plans/provision/virtual to set correct PROVISION_* variable #2722

merged 2 commits into from
Mar 4, 2024

Conversation

happz
Copy link
Collaborator

@happz happz commented Mar 1, 2024

Plus there was one lone test using the wrong one. Fixing both.

Pull Request Checklist

  • implement the feature
  • write the documentation
  • extend the test coverage
  • update the specification
  • adjust plugin docstring
  • modify the json schema
  • mention the version
  • include a release note

@happz happz added the test coverage Improvements or additions to test coverage of tmt itself label Mar 1, 2024
@happz happz added this to the 1.32 milestone Mar 1, 2024
psss
psss approved these changes Mar 1, 2024
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that was an unpleasant leftover. And I would swear I grepped through all the files. Apparently not. Thanks for catching this!

@happz happz force-pushed the fix-provision-virtual-setting-wrong-control-envvar branch from 97af461 to 1ac3351 Compare March 1, 2024 13:38
@psss psss added the ci | full test Pull request is ready for the full test execution label Mar 1, 2024
@lukaszachy
Copy link
Collaborator

Two failures:

@happz
Copy link
Collaborator Author

happz commented Mar 1, 2024

Two failures:

Indeed fits the description :/

Anyway: lovely, way fewer failures than I expected, and definitely way fewer than what I saw in my local run. Some of those will be local setup, but I did find some genuine tracebacks, for example.

@happz
Copy link
Collaborator Author

happz commented Mar 1, 2024 •
edited
Loading

Two failures:

Indeed fits the description :/

Anyway: lovely, way fewer failures than I expected, and definitely way fewer than what I saw in my local run. Some of those will be local setup, but I did find some genuine tracebacks, for example:

Edit: ok, it looked way worse than it is, it's just this single issue causing plenty of tests to fail. it manifests with a new testcloud release, 0.9.12, 0.9.10 seems to be fine.

@happz
Copy link
Collaborator Author

happz commented Mar 1, 2024 •
edited
Loading

And since the issues are known or tracked, I believe we can merge this PR :)

Aha, we cannot, provision is required :))

@happz happz force-pushed the fix-provision-virtual-setting-wrong-control-envvar branch from 1ac3351 to c3badf8 Compare March 1, 2024 19:57
@happz
Copy link
Collaborator Author

happz commented Mar 1, 2024

Added a fix for /tests/provision/user

@lukaszachy lukaszachy merged commit 8774d51 into main Mar 4, 2024
21 of 22 checks passed
@lukaszachy lukaszachy deleted the fix-provision-virtual-setting-wrong-control-envvar branch March 4, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaszachy lukaszachy lukaszachy approved these changes

@psss psss psss approved these changes

@thrix thrix Awaiting requested review from thrix thrix is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

Assignees
No one assigned
Labels
ci | full test Pull request is ready for the full test execution test coverage Improvements or additions to test coverage of tmt itself
Projects
None yet
Milestone
1.32
Development

Successfully merging this pull request may close these issues.
3 participants
@happz @lukaszachy @psss