Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootstrap unit tests for Beaker XML transformation of HW requirements #2734

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Bootstrap unit tests for Beaker XML transformation of HW requirements #2734

merged 1 commit into from
Mar 8, 2024

Conversation

happz
Copy link
Collaborator

@happz happz commented Mar 5, 2024

Pull Request Checklist

  • implement the feature

@happz happz added area | hardware Implementation of hardware requirements code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. plugin | mrack The beaker provision plugin test coverage Improvements or additions to test coverage of tmt itself labels Mar 5, 2024
@happz happz added this to the 1.33 milestone Mar 5, 2024
thrix
thrix approved these changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@thrix thrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thrix thrix mentioned this pull request Mar 5, 2024
Merged
4 tasks
@happz happz modified the milestones: 1.33, 1.32 Mar 5, 2024
@happz happz added the ci | full test Pull request is ready for the full test execution label Mar 6, 2024
psss
psss approved these changes Mar 7, 2024
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@happz
Copy link
Collaborator Author

happz commented Mar 7, 2024

Looks good, thanks!

@psss if possible, I'd recommend merging #2596 first, it adds the directories this PR builds on.

@psss psss force-pushed the testcloud-tpm-hw-constraint branch from 9c25dd1 to 14c9c26 Compare March 7, 2024 09:34
@happz happz requested a review from frantisekz as a code owner March 7, 2024 09:34
@psss
Copy link
Collaborator

psss commented Mar 7, 2024

@psss if possible, I'd recommend merging #2596 first, it adds the directories this PR builds on.

Ack, I've just reviewed it.

@psss
Copy link
Collaborator

psss commented Mar 7, 2024

@happz, could you please review the conflict which appeared after the tpm pull request rebase? Thanks.

@happz
Copy link
Collaborator Author

happz commented Mar 7, 2024

@happz, could you please review the conflict which appeared after the tpm pull request rebase? Thanks.

I'll wait for #2596 to get in - I tried to rebase, but all those "squash" commits are making a mess out of it :/

Base automatically changed from testcloud-tpm-hw-constraint to main March 7, 2024 19:04
@psss
Copy link
Collaborator

psss commented Mar 7, 2024

I'll wait for #2596 to get in - I tried to rebase, but all those "squash" commits are making a mess out of it :/

Sure, understand.

@happz happz force-pushed the mrack-bootstrap-unit-tests branch from c729462 to a0a50b5 Compare March 7, 2024 20:14
@happz
Copy link
Collaborator Author

happz commented Mar 7, 2024

I'll wait for #2596 to get in - I tried to rebase, but all those "squash" commits are making a mess out of it :/

Sure, understand.

Rebased.

@psss psss self-assigned this Mar 8, 2024
@psss psss merged commit a0a50b5 into main Mar 8, 2024
21 of 22 checks passed
@psss psss deleted the mrack-bootstrap-unit-tests branch March 8, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thrix thrix thrix approved these changes

@psss psss psss approved these changes

@dav-pascual dav-pascual Awaiting requested review from dav-pascual dav-pascual is a code owner

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

@frantisekz frantisekz Awaiting requested review from frantisekz

Assignees

@psss psss

Labels
area | hardware Implementation of hardware requirements ci | full test Pull request is ready for the full test execution code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. plugin | mrack The beaker provision plugin test coverage Improvements or additions to test coverage of tmt itself
Projects
None yet
Milestone
1.32
Development

Successfully merging this pull request may close these issues.
3 participants
@happz @psss @thrix