Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default formatting of Pint units to use symbols, not names #2736

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

happz
Copy link
Collaborator

@happz happz commented Mar 5, 2024

Instead of the default "79 mebibyte", we want "79 MiB".

Fixes #2410

Pull Request Checklist

  • implement the feature

@happz happz added this to the 1.32 milestone Mar 5, 2024
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that it already works!

@psss psss added area | hardware Implementation of hardware requirements ci | full test Pull request is ready for the full test execution labels Mar 5, 2024
Instead of the default "79 mebibyte", we want "79 MiB".

Fixes #2410
@psss psss force-pushed the pint-display-unit-symbols-not-names branch from 00636ee to c8359f8 Compare March 5, 2024 16:12
Copy link
Collaborator

@thrix thrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@psss psss merged commit 97183e3 into main Mar 6, 2024
22 checks passed
@psss psss deleted the pint-display-unit-symbols-not-names branch March 6, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area | hardware Implementation of hardware requirements ci | full test Pull request is ready for the full test execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide unit formatting that shows unit symbols instead of their full names
4 participants