Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Alpine Linux apk package manager #2788

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Support Alpine Linux apk package manager #2788

merged 1 commit into from
Mar 27, 2024

Conversation

thrix
Copy link
Collaborator

@thrix thrix commented Mar 25, 2024

Add support for apk package manager from Alpine Linux.

Unsupported debuginfo installation, seems not have a nice debuginfo-install-like solution.

Installing by path is limited to certain recognized paths. The existing apk-file solution looks flakey, it was randomly hanging and does not have a good machine readable output.

For testing we need to use a locally build alpine image which contains required packages of tmt and the unit tests.

Resolves #2694

Pull Request Checklist

  • implement the feature
  • write the documentation
  • extend the test coverage
  • include a release note

@thrix thrix requested review from janhavlin and removed request for janhavlin March 25, 2024 23:30
@thrix thrix added ci | full test Pull request is ready for the full test execution plugin | containers The podman plugin used for container provision labels Mar 25, 2024
tmt/package_managers/apk.py Outdated Show resolved Hide resolved
tmt/package_managers/apk.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this! Just a few comments.

docs/releases.rst Outdated Show resolved Hide resolved
containers/Containerfile.alpine Outdated Show resolved Hide resolved
tmt/package_managers/apk.py Outdated Show resolved Hide resolved
@psss psss added this to the 1.32 milestone Mar 26, 2024
@thrix thrix requested review from happz and psss March 26, 2024 07:56
@psss
Copy link
Collaborator

psss commented Mar 26, 2024

@thrix, /tests/unit/with-development-packages/extended seems to be failing.

@thrix
Copy link
Collaborator Author

thrix commented Mar 26, 2024

@thrix, /tests/unit/with-development-packages/extended seems to be failing.

@psss yeah, I am looking

@thrix thrix requested a review from happz March 26, 2024 18:21
Add support for `apk` package manager from Alpine Linux.

Unsupported debuginfo installation, seems not have a nice
`debuginfo-install`-like solution.

Installing by path is limited to certain recognized paths.
The existing `apk-file` solution looks flaky, it was randomly
hanging and does not have a good machine readable output.

For testing we need to use a locally build alpine image
which contains required packages of tmt and the unit tests.

Resolves #2694

Signed-off-by: Miroslav Vadkerti <[email protected]>
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now looks good, thanks!

@psss psss added the step | prepare Stuff related to the prepare step label Mar 26, 2024
@happz happz enabled auto-merge (squash) March 26, 2024 21:37
@psss psss merged commit 32f43b7 into main Mar 27, 2024
18 of 20 checks passed
@psss psss deleted the support-alpine branch March 27, 2024 06:51
@psss psss self-assigned this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci | full test Pull request is ready for the full test execution plugin | containers The podman plugin used for container provision step | prepare Stuff related to the prepare step
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tmt-1.31 breaks testing against alpine container image
3 participants