Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pyproject.toml in the plugin examples #2812

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Use pyproject.toml in the plugin examples #2812

merged 2 commits into from
Jul 30, 2024

Conversation

LecrisUT
Copy link
Contributor

@LecrisUT LecrisUT commented Apr 3, 2024

Not sure how much I can design this, ultimately I want it to address #2810, but for now there are some low-hanging fruits:

  • Use pyproject.toml in the examples

@lukaszachy
Copy link
Collaborator

/packit build

@lukaszachy
Copy link
Collaborator

/packit test

@LecrisUT LecrisUT changed the title chore: Improve examples Improve examples Apr 15, 2024
@LecrisUT LecrisUT mentioned this pull request May 24, 2024
Open
5 tasks
@happz happz added this to the 1.35 milestone Jun 5, 2024
@happz happz added packaging Changes related to the rpm packaging code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. labels Jun 12, 2024
@psss psss changed the title Improve examples Use pyproject.toml in the plugin examples Jul 19, 2024
@psss psss self-assigned this Jul 19, 2024
psss
psss approved these changes Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving this!

@psss psss added ci | full test Pull request is ready for the full test execution documentation Improvements or additions to documentation labels Jul 19, 2024
@psss
Copy link
Collaborator

psss commented Jul 19, 2024

/packit build

@psss psss added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Jul 19, 2024
@happz
Copy link
Collaborator

happz commented Jul 20, 2024

/packit build

@happz
Copy link
Collaborator

happz commented Jul 20, 2024

/packit test

@happz
Copy link
Collaborator

happz commented Jul 21, 2024

@LecrisUT there seems to be some issue on CentOS Stream 9, see https://artifacts.dev.testing-farm.io/4c90b5bc-8174-4c64-b7e3-8c5f392d5bcc/work-advancedjytot00y/plans/features/advanced/execute/data/guest/default-0/tests/plugins-15/output.txt. Maybe older-than-expected packaging infrastructure, not supporting the feature?

@LecrisUT
Copy link
Contributor Author

Weird, why does it give UNKNOWN, just double-checked and I did populate name. Maybe it's the lack of build-system.build-backend. Can you try out quickly with setuptools or hatchling, otherwise I'll try it next week (still on train rn)

@happz
Copy link
Collaborator

happz commented Jul 21, 2024

Weird, why does it give UNKNOWN, just double-checked and I did populate name. Maybe it's the lack of build-system.build-backend. Can you try out quickly with setuptools or hatchling, otherwise I'll try it next week (still on train rn)

No worries, next week is absolutely fine. It's Saturday after all. I just wanted to put a status update so you're aware.

@LecrisUT
Copy link
Contributor Author

Note to self: add --no-index to the pip install. Just as a sanity check that all dependencies are from the system. What about --no-build-isollation as well?

@LecrisUT
Copy link
Contributor Author

Ok, seems setuptools 53.0.0 is just unusable for PEP517, hatchling still works though, so might as well switch the backend.

thrix
thrix approved these changes Jul 25, 2024
View reviewed changes
Copy link
Collaborator

@thrix thrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@happz
Copy link
Collaborator

happz commented Jul 30, 2024

/packit build

@happz
Copy link
Collaborator

happz commented Jul 30, 2024

Unrelated failures, merging.

@happz happz merged commit 75bc0d1 into teemtee:main Jul 30, 2024
19 of 20 checks passed
The-Mule pushed a commit to The-Mule/tmt that referenced this pull request Oct 14, 2024
@LecrisUT @The-Mule
Use pyproject.toml in the plugin examples (teemtee#2812)
b860e6e 
Signed-off-by: Cristian Le <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thrix thrix thrix approved these changes

@lukaszachy lukaszachy lukaszachy approved these changes

@psss psss psss approved these changes

@martinhoyer martinhoyer martinhoyer approved these changes

@happz happz Awaiting requested review from happz happz is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

Assignees

@psss psss

Labels
ci | full test Pull request is ready for the full test execution code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. documentation Improvements or additions to documentation packaging Changes related to the rpm packaging status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish.
Projects
None yet
Milestone
1.35
Development

Successfully merging this pull request may close these issues.
6 participants
@LecrisUT @lukaszachy @psss @happz @thrix @martinhoyer