Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect translation of cpu.processors to Beaker #2851

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Fix incorrect translation of cpu.processors to Beaker #2851

merged 1 commit into from
Apr 23, 2024

Conversation

skycastlelily
Copy link
Collaborator

@skycastlelily skycastlelily commented Apr 12, 2024 •
edited by psss
Loading

Pull Request Checklist

  • implement the feature

@happz happz added this to the 1.33 milestone Apr 12, 2024
@happz happz added bug Something isn't working plugin | mrack The beaker provision plugin code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. labels Apr 12, 2024
@happz
Copy link
Collaborator

happz commented Apr 12, 2024 •
edited
Loading

@skycastlelily I'd suggest being more specific in your commit message. "Fix a typo" does not help a potential reader, on the other hand, something like "Fix incorrect translation of cpu.processors to Beaker" would provide much more context.

@skycastlelily skycastlelily changed the title Fix a typo Fix incorrect translation of cpu.processors to Beaker Apr 12, 2024
@skycastlelily
Copy link
Collaborator Author

@skycastlelily I'd suggest being more specific in your commit message. "Fix a typo" does not help a potential reader, on the other hand, something like "Fix incorrect translation of cpu.processors to Beaker" would provide much more context.

Thanks, and updated^^

@psss psss changed the title Fix incorrect translation of cpu.processors to Beaker Fix incorrect translation of cpu.processors to Beaker Apr 23, 2024
@psss
Copy link
Collaborator

psss commented Apr 23, 2024

/packit build

@psss psss added the ci | full test Pull request is ready for the full test execution label Apr 23, 2024
@psss
Copy link
Collaborator

psss commented Apr 23, 2024

/packit test

@psss psss self-assigned this Apr 23, 2024
@psss psss merged commit 7201ada into teemtee:main Apr 23, 2024
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@happz happz happz approved these changes

@psss psss psss approved these changes

@therazix therazix therazix approved these changes

@dav-pascual dav-pascual Awaiting requested review from dav-pascual dav-pascual is a code owner

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@thrix thrix Awaiting requested review from thrix thrix is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

Assignees

@psss psss

Labels
bug Something isn't working ci | full test Pull request is ready for the full test execution code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. plugin | mrack The beaker provision plugin
Projects
None yet
Milestone
1.33
Development

Successfully merging this pull request may close these issues.
4 participants
@skycastlelily @happz @psss @therazix