Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let plugin go() method return a value [Step results #1] #2963

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

happz
Copy link
Collaborator

@happz happz commented May 28, 2024

A preparation patch to introduce parametrized return value to types and annotations. No plugin returns any value yet, only type changes and minor go() refactoring is covered.

Pull Request Checklist

  • implement the feature

@happz happz added this to the 1.35 milestone May 28, 2024
@happz happz requested a review from martinhoyer as a code owner June 2, 2024 18:50
@happz happz force-pushed the plugins-go-returns-value branch from 0d0587a to 35b80aa Compare June 2, 2024 18:52
@happz happz added the ci | full test Pull request is ready for the full test execution label Jun 13, 2024
@happz happz changed the title Let plugin go() method return a value Let plugin go() method return a value [Step results #1] Jun 15, 2024
@happz happz added the code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. label Jun 15, 2024
@happz happz added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Jul 16, 2024
A preparation patch to introduce parametrized return value to types and
annotations. No plugin returns any value yet, only type type changes and
minor `go()` refactoring is covered.
@psss psss force-pushed the plugins-go-returns-value branch from 51ef2e9 to 36559dc Compare July 17, 2024 15:38
@psss psss self-assigned this Jul 18, 2024
@psss
Copy link
Collaborator

psss commented Jul 18, 2024

Just irrelevant multihost test failures --> merging.

@psss psss merged commit e93d03b into main Jul 18, 2024
18 of 19 checks passed
@psss psss deleted the plugins-go-returns-value branch July 18, 2024 07:37
The-Mule pushed a commit to The-Mule/tmt that referenced this pull request Oct 14, 2024
A preparation patch to introduce parametrized return value to
types and annotations. No plugin returns any value yet, only
type changes and minor `go()` refactoring is covered.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci | full test Pull request is ready for the full test execution code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants