-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save results before raising exception #2996
Conversation
This is an important item for Upgrades & Conversions, marking as a |
This is essential for storing at least partial results and making report work if there was some issue with the system (e.g. became unreachable) during the execution.
When waking up an unfinished step, we should not clear the workdir unless the step in question is actually enabled, which covers the scenario when user wants to give the step another try.
Let's fetch all artifacts stored in the plan data directory after each test execution to prevent losing useful information if the guest becomes unresponsive.
9d67ce8
to
fa2c32a
Compare
/packit build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me and works. I don't know enough this code to 'approve' stuff though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, no comments from me
This is essential for storing at least partial results and making `report` work if there was some issue with the system (e.g. became unreachable) during the execution. Let's fetch all artifacts stored in the plan data directory after each test execution to prevent losing useful information if the guest becomes unresponsive. As part of the solution, when waking up an unfinished step, we should not clear the workdir unless the step in question is actually enabled, which covers the scenario when user wants to give the step another try. Co-authored-by: Petr Šplíchal <[email protected]>
This is essential for storing at least partial results and making report work if there was some issue with the system (e.g. became unreachable) during the execution.
Pull Request Checklist