Make test shell wrapper filename even more unique #2998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszachy
approved these changes
Jun 7, 2024
lukaszachy
added
the
priority | must
|
/packit test |
|
Bunch of |
happz
force-pushed
the
test-wrapper-more-unique
branch
from
48f3c5e
to
687a196
Compare
psss
approved these changes
Jun 10, 2024
To prevent accidental reuse of the wrapper, reported in #2997, and improve investigation by saving all wrappers, make the test shell wrapper filename even more unique that it already was. Besides the phase and guest names, include also test name and its serial number. That should make the filename unlike any other filename created for other tests. See #2997
psss
force-pushed
the
test-wrapper-more-unique
branch
from
687a196
to
bf7e5bb
Compare
happz
added
the
status | ready for merge
|
Unrelated test failures, enough approvals, merging. |
falconizmi
pushed a commit
that referenced
this pull request
Jun 17, 2024
To prevent accidental reuse of the wrapper, reported in #2997, and improve investigation by saving all wrappers, make the test shell wrapper filename even more unique that it already was. Besides the phase and guest names, include also test name and its serial number. That should make the filename unlike any other filename created for other tests. See #2997
The-Mule
pushed a commit
to The-Mule/tmt
that referenced
this pull request
Oct 14, 2024
To prevent accidental reuse of the wrapper, reported in teemtee#2997, and improve investigation by saving all wrappers, make the test shell wrapper filename even more unique that it already was. Besides the phase and guest names, include also test name and its serial number. That should make the filename unlike any other filename created for other tests. See teemtee#2997
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent accidental reuse of the wrapper, reported in #2997, and improve investigation by saving all wrappers, make the test shell wrapper filename even more unique that it already was. Besides the phase and guest names, include also test name and its serial number. That should make the filename unlike any other filename created for other tests.
See #2997
Pull Request Checklist