Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pre-commit checks #3023

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Bump pre-commit checks #3023

merged 1 commit into from
Jun 20, 2024

Conversation

happz
Copy link
Collaborator

@happz happz commented Jun 18, 2024

Includes some changes needed to appease new versions of various checks.

Pull Request Checklist

  • implement the feature

@happz happz added code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. test coverage Improvements or additions to test coverage of tmt itself ci | full test Pull request is ready for the full test execution labels Jun 18, 2024
@happz happz added this to the 1.35 milestone Jun 18, 2024
@happz happz mentioned this pull request Jun 18, 2024
1 task
Copy link
Collaborator

@martinhoyer martinhoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I had this also prepared to open once the ruff rules update is merged.

fyi, in case it saves someone needing to check it, ansible.builtin.dnf can use yum backend https://docs.ansible.com/ansible/latest/collections/ansible/builtin/dnf_module.html#parameter-use_backend

@happz happz added the priority | must high priority, must be included in the next release label Jun 18, 2024
@happz
Copy link
Collaborator Author

happz commented Jun 18, 2024

Adding a must label to pull in fixes for issues pre-commit started complaining today.

Includes some changes needed to appease new versions of various checks.
@happz happz added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Jun 20, 2024
@happz
Copy link
Collaborator Author

happz commented Jun 20, 2024

All failed tests are unrelated, merging to prevent pre-commit from ruining more PRs.

@happz happz merged commit b5dce88 into main Jun 20, 2024
16 of 19 checks passed
@happz happz deleted the bump-pre-commit-checks branch June 20, 2024 14:00
The-Mule pushed a commit to The-Mule/tmt that referenced this pull request Oct 14, 2024
Includes some changes needed to appease new versions of various checks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci | full test Pull request is ready for the full test execution code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. priority | must high priority, must be included in the next release status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. test coverage Improvements or additions to test coverage of tmt itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants