Move abort detection into test invocation

[happz]

Similar to reboot detection, hiding the details from individual execution plugins.

Pull Request Checklist

• implement the feature

[therazix]

LGTM. Just one question. Shouldn't the check_abort_file method be removed from the ExecutePlugin class as it is no longer used?

[happz]

@therazix absolutely, removed in e0d050c

[martinhoyer]

Nice, I just wonder how it worked before, when there was:

if (abort or self.data.exit_first and
    result.result not in (ResultOutcome.PASS, ResultOutcome.INFO)):

and now we're iterating for result in invocation.results. Was that a bug?

[happz]

Nice, I just wonder how it worked before, when there was:

if (abort or self.data.exit_first and
    result.result not in (ResultOutcome.PASS, ResultOutcome.INFO)):

and now we're iterating for result in invocation.results. Was that a bug?

I believe it was a bug, because it was checking result.result, and result was whatever the loop saw as the last item, most likely invocation.results[-1]:

                if abort:
                    for result in invocation.results:
                        # In case of aborted all results in list will be aborted
                        result.note = 'aborted'

...

                for result in invocation.results:
                    logger.verbose(
                        f"{_format_duration(result)} {result.show()} [{progress}]",
                        shift=shift)

...

                if (abort or self.data.exit_first and
                        result.result not in (ResultOutcome.PASS, ResultOutcome.INFO)):

So only the last result was considered, which does not seem right.

[thrix]

/packit test