Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix normalization of playbook/playbooks keys of ansible plugin #3053

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Fix normalization of playbook/playbooks keys of ansible plugin #3053

merged 1 commit into from
Jul 9, 2024

Conversation

happz
Copy link
Collaborator

@happz happz commented Jun 27, 2024

Pull Request Checklist

  • implement the feature

@happz happz added bug Something isn't working step | prepare Stuff related to the prepare step step | finish Stuff related to the finish step plugin | ansible The ansible plugins labels Jun 27, 2024
@happz happz added this to the 1.35 milestone Jun 27, 2024
@happz happz linked an issue Jun 27, 2024 that may be closed by this pull request
Exception when running Ansible preparation from CLI #3051
Closed
@mizdebsk mizdebsk mentioned this pull request Jun 28, 2024
Closed
8 tasks
@happz happz added the priority | must high priority, must be included in the next release label Jul 9, 2024
psss
psss approved these changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@psss psss added the ci | full test Pull request is ready for the full test execution label Jul 9, 2024
@psss psss force-pushed the prepare-ansible-invalid-normalization-of-cli branch from b265772 to 5368071 Compare July 9, 2024 12:12
@happz happz added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Jul 9, 2024
@happz happz enabled auto-merge (squash) July 9, 2024 12:22
@psss
Copy link
Collaborator

psss commented Jul 9, 2024

Hm, copr builds failed because of:

!! Copr timeout => sending INT
Copr build error: Build failed

Seems like some infra issue, let's try again.

@psss
Copy link
Collaborator

psss commented Jul 9, 2024

/packit test

@happz happz merged commit e4e9448 into main Jul 9, 2024
12 of 19 checks passed
@happz happz deleted the prepare-ansible-invalid-normalization-of-cli branch July 9, 2024 13:31
happz added a commit that referenced this pull request Jul 9, 2024
@happz
Fix normalization of regular expression lists
69c113b 
It got broken by changes introduced in
#3053
@happz happz mentioned this pull request Jul 9, 2024
Merged
1 task
happz added a commit that referenced this pull request Jul 10, 2024
@happz
Fix normalization of regular expression lists (#3083)
d332771 
It got broken by changes introduced in
#3053
@psss psss mentioned this pull request Jul 10, 2024
Closed
The-Mule pushed a commit to The-Mule/tmt that referenced this pull request Oct 14, 2024
@happz @The-Mule
Fix normalization of playbook/playbooks keys of ansible plugin (teemt…
9c9ff8e 
…ee#3053)
The-Mule pushed a commit to The-Mule/tmt that referenced this pull request Oct 14, 2024
@happz @The-Mule
Fix normalization of regular expression lists (teemtee#3083)
a00327e 
It got broken by changes introduced in
teemtee#3053
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psss psss psss approved these changes

@therazix therazix therazix approved these changes

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@thrix thrix Awaiting requested review from thrix thrix is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

Assignees
No one assigned
Labels
bug Something isn't working ci | full test Pull request is ready for the full test execution plugin | ansible The ansible plugins priority | must high priority, must be included in the next release status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. step | finish Stuff related to the finish step step | prepare Stuff related to the prepare step
Projects
None yet
Milestone
1.35
Development

Successfully merging this pull request may close these issues.

Exception when running Ansible preparation from CLI
3 participants
@happz @psss @therazix