-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add install
prepare plugin using install
into tmt try
#3071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
falconizmi
requested review from
psss,
lukaszachy,
happz,
thrix and
janhavlin
as code owners
July 2, 2024 11:48
falconizmi
changed the title
Iquwarah tmt try package
Add Jul 2, 2024
package
prepare plugin using install
into tmt try
falconizmi
added
step | prepare
Stuff related to the prepare step
command | try
tmt try command
labels
Jul 2, 2024
falconizmi
force-pushed
the
iquwarah-tmt-try-epel
branch
from
July 9, 2024 06:53
6327ea5
to
6fd0799
Compare
Isn't it more natural to call that option install? As in |
falconizmi
force-pushed
the
iquwarah-tmt-try-package
branch
from
July 11, 2024 09:20
778933e
to
e09d1e0
Compare
falconizmi
changed the title
Add
Add Jul 11, 2024
package
prepare plugin using install
into tmt tryinstall
prepare plugin using install
into tmt try
falconizmi
added
the
ci | full test
Pull request is ready for the full test execution
label
Jul 11, 2024
falconizmi
force-pushed
the
iquwarah-tmt-try-package
branch
from
July 11, 2024 10:12
b3ed948
to
09659c3
Compare
falconizmi
force-pushed
the
iquwarah-tmt-try-epel
branch
2 times, most recently
from
July 29, 2024 14:37
c2806be
to
9ea8e3b
Compare
falconizmi
force-pushed
the
iquwarah-tmt-try-package
branch
from
July 30, 2024 11:47
8ec34df
to
f6f4796
Compare
falconizmi
force-pushed
the
iquwarah-tmt-try-epel
branch
from
August 1, 2024 08:20
9ea8e3b
to
623b918
Compare
falconizmi
force-pushed
the
iquwarah-tmt-try-epel
branch
from
September 12, 2024 11:56
623b918
to
f322b2b
Compare
falconizmi
force-pushed
the
iquwarah-tmt-try-package
branch
from
September 12, 2024 13:07
b9d3105
to
66c6d29
Compare
happz
requested changes
Sep 16, 2024
falconizmi
force-pushed
the
iquwarah-tmt-try-epel
branch
3 times, most recently
from
September 16, 2024 14:11
66a661a
to
241dda6
Compare
falconizmi
force-pushed
the
iquwarah-tmt-try-package
branch
from
September 16, 2024 14:37
66c6d29
to
3e77301
Compare
falconizmi
force-pushed
the
iquwarah-tmt-try-package
branch
from
September 24, 2024 09:45
015ae97
to
eb444d6
Compare
happz
reviewed
Sep 24, 2024
falconizmi
force-pushed
the
iquwarah-tmt-try-package
branch
from
September 24, 2024 13:51
75ab54e
to
880c1b3
Compare
happz
approved these changes
Sep 30, 2024
psss
force-pushed
the
iquwarah-tmt-try-package
branch
from
September 30, 2024 21:37
880c1b3
to
1b7d1f5
Compare
psss
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing this! Looks good. In 1b7d1f5 I've just adjusted the option description (we support non-local and non-rpm packages as well) and the release note a bit.
psss
added
the
status | ready for merge
The only missing piece is to do the rebase the current 'main' and let the CI finish.
label
Sep 30, 2024
fix handle options in tmt try Drop unnecessary prepare- from phase name
fix `epel` release note in tmt try Add mention of prepare/feature plugin in tmt try release notes Adjust text length to match the header Fix links to plugins (#3104) Add missing full stop
The extra action for handling options should not be needed. Plus it breaks use cases like `tmt try --epel` with tests. Included a few minor style adjustments.
Drop unnecessary prepare- from phase name
Co-authored-by: Miloš Prchlík <[email protected]>
psss
force-pushed
the
iquwarah-tmt-try-package
branch
from
October 1, 2024 07:29
1b7d1f5
to
e540617
Compare
/packit test |
The-Mule
pushed a commit
to The-Mule/tmt
that referenced
this pull request
Oct 14, 2024
Co-authored-by: Ismail Ibrahim Quwarah <[email protected]> Co-authored-by: Petr Šplíchal <[email protected]> Co-authored-by: Miloš Prchlík <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci | full test
Pull request is ready for the full test execution
command | try
tmt try command
status | ready for merge
The only missing piece is to do the rebase the current 'main' and let the CI finish.
step | prepare
Stuff related to the prepare step
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist