Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Polarion field which stores tmt id #3080

Merged
merged 4 commits into from
Jul 28, 2024
Merged

Conversation

KwisatzHaderach
Copy link
Collaborator

@KwisatzHaderach KwisatzHaderach commented Jul 4, 2024

There is a requirement to use different field to store tmt id in Polarion.
This patch changes which field is used for any new imported/exported test case to newly created 'tmtuuid' field.
Any existing cases will still be found with existing ids in current field so no need to export again just for this change, just during the next export the id will be exported to the new field.

Pull Request Checklist

  • implement the feature
  • write the documentation
  • include a release note

@KwisatzHaderach KwisatzHaderach added command | import The import command command | export The export command plugin | polarion Plugins implementing the Polarion integration labels Jul 4, 2024
@KwisatzHaderach KwisatzHaderach added this to the 1.35 milestone Jul 4, 2024
@KwisatzHaderach KwisatzHaderach force-pushed the polarion_id_field_change branch 2 times, most recently from 1081d22 to 6677d01 Compare July 9, 2024 09:41
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just two nitpicks.

tmt/convert.py Outdated Show resolved Hide resolved
tmt/export/polarion.py Outdated Show resolved Hide resolved
@happz happz added status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. ci | full test Pull request is ready for the full test execution labels Jul 10, 2024
@happz
Copy link
Collaborator

happz commented Jul 11, 2024

@KwisatzHaderach I'm afraid there's at least one failed polarion test in /plans/remote/polarion, can you take a look at it?

@happz happz removed the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Jul 12, 2024
@KwisatzHaderach
Copy link
Collaborator Author

Fixed the tests (hopefully) here teemtee/tests#8 which of these chickens/eggs we merge first?

@psss
Copy link
Collaborator

psss commented Jul 16, 2024

Great, thanks! Let's verify the tests are green in 44a9737 and then merge the test change first.

@psss psss force-pushed the polarion_id_field_change branch from 44a9737 to 95511d6 Compare July 16, 2024 07:31
@psss psss requested a review from martinhoyer as a code owner July 16, 2024 07:31
@psss psss force-pushed the polarion_id_field_change branch from 95511d6 to 3bb63ad Compare July 16, 2024 13:51
@psss
Copy link
Collaborator

psss commented Jul 16, 2024

Rebased on the latest main and dropped the temporary hack to actually execute tests.

@happz happz added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Jul 25, 2024
@happz
Copy link
Collaborator

happz commented Jul 28, 2024

Unrelated failures, merging.

@happz happz merged commit 50d0de2 into main Jul 28, 2024
18 of 19 checks passed
@happz happz deleted the polarion_id_field_change branch July 28, 2024 12:45
The-Mule pushed a commit to The-Mule/tmt that referenced this pull request Oct 14, 2024
Co-authored-by: Petr Matyas <[email protected]>
Co-authored-by: Petr Šplíchal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci | full test Pull request is ready for the full test execution command | export The export command command | import The import command plugin | polarion Plugins implementing the Polarion integration status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants