Fix collection of know keys for test, plan and story T001 linter #3084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
happz
added
bug
happz
requested review from
psss,
lukaszachy,
thrix and
janhavlin
as code owners
lukaszachy
approved these changes
Jul 16, 2024
psss
approved these changes
Jul 19, 2024
The original code did not handle fields with dashes (`restart-max-count`) and internal fields (`serial-number`).
psss
force-pushed
the
fix-collection-of-known-fields-for-linter
branch
from
dcd6142
to
6a69b43
Compare
|
Extended the test coverage a bit in 6a69b43 to check that internal keys are correctly reported as invalid (which was not the case before the change). |
The-Mule
pushed a commit
to The-Mule/tmt
that referenced
this pull request
Oct 14, 2024
…mtee#3084) The original code did not handle fields with dashes (`restart-max-count`) and internal fields (`serial-number`). Extend the test coverage a bit to check that internal keys are reported as invalid. Co-authored-by: Petr Šplíchal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code did not handle fields with dashes (
restart-max-count) and internal fields (serial-number).Pull Request Checklist