Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry on error 504 from ReportPortal #3092

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Retry on error 504 from ReportPortal #3092

merged 2 commits into from
Aug 1, 2024

Conversation

kkaarreell
Copy link
Collaborator

@kkaarreell kkaarreell commented Jul 18, 2024 •
edited
Loading

Introduces two changes to the reportportal plugin:

  • enable request retry on HTTP error 504
  • strip unprintable characters from uploaded logs as those were causing errors on RP side

Pull Request Checklist

  • implement the feature
  • write the documentation
  • extend the test coverage
  • update the specification
  • adjust plugin docstring
  • modify the json schema
  • mention the version
  • include a release note

@psss psss marked this pull request as draft July 18, 2024 07:38
@psss psss changed the title [DRAFT] Ignore Error 504 from ReportPortal Ignore Error 504 from ReportPortal Jul 18, 2024
@Athwale
Copy link

Athwale commented Jul 19, 2024

I can confirm this works with using the modified file in my run.

Read file '/var/tmp/tmt/run-061/plans/plan-1/execute/data/guest/default-0/rhel_tcpdump/Security/tcpdump-Buffer-over-read-in-function-20/output.txt'.
        Response code from the endpoint: 504
        Message from the endpoint:
            <html><body><h1>504 Gateway Time-out</h1>
            The server didn't respond in time.
            </body></html>
        Ignoring RP timeout response 
    Read file '/var/tmp/tmt/run-061/plans/plan-1/execute/data/guest/default-0/rhel_tcpdump/Security/tcpdump-Buffer-over-read-in-function-20/journal.txt'.

The results from this failed report were uploaded to RP anyway.

@martinhoyer martinhoyer added this to the 1.35 milestone Jul 30, 2024
@kkaarreell kkaarreell changed the title Ignore Error 504 from ReportPortal Retry on error 504 from ReportPortal Jul 30, 2024
@kkaarreell kkaarreell force-pushed the ks_rp_504 branch 3 times, most recently from acc3225 to 5bd1a88 Compare July 30, 2024 12:07
@4N0body5
Copy link
Collaborator

I can confirm, this resolves the following problem:

Received non-ok status code from ReportPortal: {"errorCode":5000,"message":"Unclassified error [org.hibernate.exception.DataException: could not execute statement]"}

Tested on another reproducer - reporting scrub test.

@4N0body5 4N0body5 added step | report Stuff related to the report step priority | must high priority, must be included in the next release labels Jul 31, 2024
@kkaarreell kkaarreell marked this pull request as ready for review July 31, 2024 09:36
@thrix thrix requested review from happz and thrix July 31, 2024 11:03
@happz happz added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Jul 31, 2024
@happz happz added the ci | full test Pull request is ready for the full test execution label Aug 1, 2024
@happz
Copy link
Collaborator

happz commented Aug 1, 2024

/packit test

@happz
Copy link
Collaborator

happz commented Aug 1, 2024

Unrelated failure, merging.

@happz happz merged commit 87482f5 into main Aug 1, 2024
19 of 20 checks passed
@happz happz deleted the ks_rp_504 branch August 1, 2024 11:50
@waynesun09 waynesun09 mentioned this pull request Aug 26, 2024
Open
The-Mule pushed a commit to The-Mule/tmt that referenced this pull request Oct 14, 2024
@kkaarreell @The-Mule
Retry on error 504 from ReportPortal (teemtee#3092)
26a265b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@happz happz happz approved these changes

@lukaszachy lukaszachy lukaszachy approved these changes

@psss psss Awaiting requested review from psss psss is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

@thrix thrix Awaiting requested review from thrix thrix is a code owner

Assignees
No one assigned
Labels
ci | full test Pull request is ready for the full test execution priority | must high priority, must be included in the next release status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. step | report Stuff related to the report step
Projects
None yet
Milestone
1.35
Development

Successfully merging this pull request may close these issues.
7 participants
@kkaarreell @Athwale @4N0body5 @happz @thrix @lukaszachy @martinhoyer