Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct the description for where under finish #3136

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Correct the description for where under finish #3136

merged 1 commit into from
Aug 13, 2024

Conversation

mcasquer
Copy link
Contributor

@mcasquer mcasquer commented Aug 7, 2024 •
edited
Loading

finish,where: corrects the spec description

The first sentence of the description is identical
to the one from prepare > where. Adjust the verb to
make sense.

Pull Request Checklist

  • implement the feature
  • write the documentation
  • extend the test coverage
  • update the specification
  • adjust plugin docstring
  • modify the json schema
  • mention the version
  • include a release note

@mcasquer
Copy link
Contributor Author

mcasquer commented Aug 7, 2024

It's been copied from:

tmt/spec/plans/prepare.fmf

Lines 175 to 176 in 93baf66

is often necessary to perform different preparation tasks on
individual guests. The ``where`` key allows to select guests

@mcasquer mcasquer marked this pull request as ready for review August 7, 2024 11:46
@happz happz added documentation Improvements or additions to documentation code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. labels Aug 7, 2024
@happz happz added this to the 1.36 milestone Aug 7, 2024
@mcasquer @psss
Correct the description for where under finish
469ed22 
The first sentence of the description is identical
to the one from prepare > where. Adjust the verb to
make sense.

Signed-off-by: mcasquer <[email protected]>
@psss psss force-pushed the correct_where_duplication branch from 93baf66 to 469ed22 Compare August 13, 2024 08:08
@psss psss changed the title finish,where: corrects the spec description Correct the description for where under finish Aug 13, 2024
psss
psss approved these changes Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the typo! We're not using prefixes for commit messages so I've updated it. See also the commit recommendations.

@psss psss self-assigned this Aug 13, 2024
@psss psss merged commit 469ed22 into teemtee:main Aug 13, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@happz happz happz approved these changes

@psss psss psss approved these changes

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@thrix thrix Awaiting requested review from thrix thrix is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

Assignees

@psss psss

Labels
code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. documentation Improvements or additions to documentation
Projects
None yet
Milestone
1.36
Development

Successfully merging this pull request may close these issues.
3 participants
@mcasquer @happz @psss