-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pre-commit hooks update; mypy, ruff fixes #3142
Conversation
d19371c
to
7aae691
Compare
Please remember to rebase your changes on top of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (with some small comments)
No worries, he who merges is always limited to fast-forward only, therefore rebase to |
Removing explicit container_field overloads for ConainerClass and ContainerInstance to have an unified return output. According to mypy, it would never got to the second instance of overloaded container_field, as the first one is same or broader.
Replacing regex flag aliases with full name to pass FURB167. Removing one .readlines() usage for efficiency (FURB129). Flynt f-strings checks passes, ignoring tests/unit dir.
Unrelated failure, merging. |
Update pre-commit hooks, update Ruff, enable flynt and refurb ruff rules and address newly found errors Removing explicit container_field overloads for ConainerClass and ContainerInstance to have a unified return output. According to mypy, it would never got to the second instance of overloaded container_field, as the first one is the same or broader. Replacing regex flag aliases with full name to pass FURB167. Removing one .readlines() usage for efficiency (FURB129). Flynt f-strings check passes, ignoring tests/unit dir. Co-authored-by: Miloš Prchlík <[email protected]>
New mypy version was throwing error. I've done my best to address them, but definitely needs @happz's eyes.
Refurb rules are now out of 'preview' and surprisingly, tmt passes almost everything with flying colors 🚀.
Only thing it didn't like regex flag aliases and readlines(), which was used only in one place.
Not updating to latest version of pyright. There are errors linked to UnserializeCallback, which I couldn't properly figure out.
FWIW - from https:/microsoft/pyright/releases 1.1.372: