Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the operator to be not equal in string values #3170

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Fix the operator to be not equal in string values #3170

merged 1 commit into from
Aug 27, 2024

Conversation

mcasquer
Copy link
Contributor

@mcasquer mcasquer commented Aug 27, 2024 •
edited
Loading

As the document explains in the introduction, ! is not an available operator, so logically it should be !=

Pull Request Checklist

  • implement the feature
  • write the documentation
  • extend the test coverage
  • update the specification
  • adjust plugin docstring
  • modify the json schema
  • mention the version
  • include a release note

@mcasquer mcasquer marked this pull request as ready for review August 27, 2024 08:05
@happz happz added documentation Improvements or additions to documentation code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. labels Aug 27, 2024
@happz happz added this to the 1.36 milestone Aug 27, 2024
thrix
thrix approved these changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@thrix thrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@happz happz added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Aug 27, 2024
@mcasquer @happz
Fix the operator to be not equal in string values
4a50c7c 
As the document explains in the introduction, '!' is
not an available operator, so logically it should be
'!='

Signed-off-by: mcasquer <[email protected]>
@happz
Copy link
Collaborator

happz commented Aug 27, 2024

Documentation-only, not going to wait for the full battery of tests.

@happz happz merged commit 5c3c4cb into teemtee:main Aug 27, 2024
11 of 12 checks passed
The-Mule pushed a commit to The-Mule/tmt that referenced this pull request Oct 14, 2024
@mcasquer @The-Mule
Fix the operator to be not equal in string values (teemtee#3170)
e59e105 
As the document explains in the introduction, '!' is
not an available operator, so logically it should be
'!='

Signed-off-by: mcasquer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thrix thrix thrix approved these changes

@janhavlin janhavlin janhavlin approved these changes

@therazix therazix therazix approved these changes

@psss psss Awaiting requested review from psss psss is a code owner

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@happz happz Awaiting requested review from happz happz is a code owner

Assignees
No one assigned
Labels
code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. documentation Improvements or additions to documentation status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish.
Projects
None yet
Milestone
1.36
Development

Successfully merging this pull request may close these issues.
5 participants
@mcasquer @happz @thrix @janhavlin @therazix