Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix command detection in the out-of-session test #3216

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Fix command detection in the out-of-session test #3216

merged 1 commit into from
Sep 13, 2024

Conversation

psss
Copy link
Collaborator

@psss psss commented Sep 13, 2024 •
edited
Loading

The /tests/execute/reboot/out-of-session test was not safely detecting the podman exec command which could result in multiple lines returned. Let's make sure that there is just a sigle line.

Pull Request Checklist

  • extend the test coverage

@psss psss mentioned this pull request Sep 13, 2024
Merged
@happz happz added code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. test coverage Improvements or additions to test coverage of tmt itself code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. labels Sep 13, 2024
@happz happz added this to the 1.37 milestone Sep 13, 2024
@psss psss added the ci | full test Pull request is ready for the full test execution label Sep 13, 2024
@psss
Fix command detection in the out-of-session test
0b4a2d0 
The `/tests/execute/reboot/out-of-session` test was not safely
detecting the `podman exec` command which could result in multiple
lines returned. Let's make sure that there is just a sigle line.
@psss psss added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Sep 13, 2024
@psss psss self-assigned this Sep 13, 2024
@psss psss merged commit 4b3394b into main Sep 13, 2024
22 checks passed
@psss psss deleted the out-of-session-test branch September 13, 2024 21:42
The-Mule pushed a commit to The-Mule/tmt that referenced this pull request Oct 14, 2024
@psss @The-Mule
Fix command detection in the out-of-session test (teemtee#3216)
5fd190f 
The `/tests/execute/reboot/out-of-session` test was not safely
detecting the `podman exec` command which could result in multiple
lines returned. Let's make sure that there is just a sigle line.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@happz happz happz approved these changes

@martinhoyer martinhoyer martinhoyer approved these changes

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@thrix thrix Awaiting requested review from thrix thrix is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

Assignees

@psss psss

Labels
ci | full test Pull request is ready for the full test execution code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. test coverage Improvements or additions to test coverage of tmt itself
Projects
None yet
Milestone
1.37
Development

Successfully merging this pull request may close these issues.
3 participants
@psss @happz @martinhoyer