Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing where, name and order keywords into schema #3225

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

bajertom
Copy link
Collaborator

Pull Request Checklist

  • implement the feature
  • modify the json schema

Fixes issue #2984 and #3008.
Regarding #3008 - where (and order and name) is present in all other prepare schemas (except errata). Not sure whether to include it in this one as well?

@happz
Copy link
Collaborator

happz commented Sep 18, 2024

Regarding #3008 - where (and order and name) is present in all other prepare schemas (except errata).

where should be also accepted by all prepare plugins, including errata.

Not sure whether to include it in this one as well?

I'd go for it, you can include where in the subject, yet another key that should be accepted, it's just nobody pointed it out in the issues.

@bajertom bajertom force-pushed the feature-schema-false-positives branch from d4a1f11 to 158b1c0 Compare September 18, 2024 14:22
@bajertom
Copy link
Collaborator Author

I've included where, name and order into errata and feature schemas. In shell and ansible schemas it is included via reference to common.yaml schema.

@bajertom bajertom force-pushed the feature-schema-false-positives branch 2 times, most recently from ec1db7b to 97caee8 Compare September 18, 2024 14:34
@bajertom bajertom added the ci | full test Pull request is ready for the full test execution label Sep 19, 2024
@bajertom
Copy link
Collaborator Author

/packit test

@bajertom
Copy link
Collaborator Author

Extended unit tests failing due to change in dnf stdout x stderr, fixed here #3227.

@psss psss changed the title Add 'name' and 'order' keywords to feature schema Add name and order keywords to feature schema Sep 19, 2024
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@psss psss changed the title Add name and order keywords to feature schema Add missing where, name and order keywords into schema Sep 20, 2024
@psss psss added the code | schema Schema used for validating config files label Sep 20, 2024
@psss psss linked an issue Sep 20, 2024 that may be closed by this pull request
@psss psss added this to the 1.37 milestone Sep 20, 2024
@psss psss force-pushed the feature-schema-false-positives branch from 97caee8 to 6a0d8b5 Compare September 20, 2024 12:56
@psss psss self-assigned this Sep 20, 2024
@psss psss merged commit fb19fb0 into main Sep 20, 2024
23 checks passed
@psss psss deleted the feature-schema-false-positives branch September 20, 2024 14:48
The-Mule pushed a commit to The-Mule/tmt that referenced this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci | full test Pull request is ready for the full test execution code | schema Schema used for validating config files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature schema missing name, order
3 participants