Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not traceback upon an empty docstring #3233

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Do not traceback upon an empty docstring #3233

merged 1 commit into from
Sep 23, 2024

Conversation

psss
Copy link
Collaborator

@psss psss commented Sep 23, 2024

Providing no docstring for a click command would result into a confusing list index out of range error. Check for the rendered paragraphs first to prevent the traceback.

Providing no docstring for a `click` command would result into a
confusing `list index out of range` error. Check for the rendered
paragraphs first to prevent the traceback.
@psss psss added code | cli Changes related to the command line interface code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. labels Sep 23, 2024
@psss psss added this to the 1.37 milestone Sep 23, 2024
@psss
Copy link
Collaborator Author

psss commented Sep 23, 2024

@tkoscieln ran into this when implementing the new tmt link command. Trivial change.

@psss psss merged commit 1238dca into main Sep 23, 2024
14 of 23 checks passed
@psss psss deleted the empty-docstring branch September 23, 2024 12:48
@psss psss self-assigned this Sep 23, 2024
The-Mule pushed a commit to The-Mule/tmt that referenced this pull request Oct 14, 2024
Providing no docstring for a `click` command would result into a
confusing `list index out of range` error. Check for the rendered
paragraphs first to prevent the traceback.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code | cli Changes related to the command line interface code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants