Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to set number of CPUs for virtual run #3292

Closed

Conversation

jkonecny12
Copy link

Without this some tests could be pretty slow because standard is 2 CPUs which is not much these days.

Hi, I'm fighting with mypy and other things and I have hard time to work on this. So I'm creating a PR if someone wants to help me with debugging to finish this if you see the benefit.

Pull Request Checklist

  • implement the feature
  • write the documentation
  • extend the test coverage
  • update the specification
  • adjust plugin docstring
  • modify the json schema
  • mention the version
  • include a release note

Without this some tests could be pretty slow because standard is 2 CPUs
which is not much these days.
@happz
Copy link
Collaborator

happz commented Oct 16, 2024

@jkonecny12 can you try adding cpu.processors HW requirement to your plans? That should do the trick. See https://tmt.readthedocs.io/en/stable/spec/hardware.html#cpu for the specification.

hardware:
  cpu:
    processors: 79

Or, via command line:

--hardware 'cpu.processors=79'

AFAICT this is not documented correctly, I'll fix that, but that should be all that's needed. And the best thing, the same should work for Beaker and Testing Farm too ;)

Edit: documentation update added in #3293

@jkonecny12
Copy link
Author

Sounds great. I wouldn't expect that this is hidden under hardware when the memory is just top class citizen.

@jkonecny12
Copy link
Author

Tested and it works.

@jkonecny12 jkonecny12 closed this Oct 16, 2024
@happz
Copy link
Collaborator

happz commented Oct 16, 2024

Sounds great. I wouldn't expect that this is hidden under hardware when the memory is just top class citizen.

Yeah, memory and disk happened before I could force hardware into the system :) Internally, they just add memory: .. and disk: ... HW requirements, and if I could, I would remove them in a heartbeat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants