Update git-clone task and document changes in behaviour

[divyansh42]

Changes

Earlier git-clone assumes master as default branch, but after tektoncd/pipeline#2835
master is no more default branch. Hence, updated the git clone task to
fetch a remote repository's default branch instead of assuming master
when revision is "".

Closes: #390

Signed-off-by: Divyansh42 [email protected]

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes docs (if user facing)
• Commit messages follow commit message best practices
• Yaml file complies with yamllint rules.
• Complies with Catalog Orgainization TEP, see example. Note An issue has been filed to automate this validation

  • File path follows <kind>/<name>/<version>/name.yaml

  • Has README.md at <kind>/<name>/<version>/README.md

  • Has mandatory metadata.labels - app.kubernetes.io/version the same as the <version> of the resource

  • Has mandatory metadata.annotations tekton.dev/pipelines.minVersion

  • mandatory spec.description follows the convention

      ```
    
      spec:
        description: >-
          one line summary of the resource
    
          Paragraph(s) to describe the resource.
      ```
    

See the contribution guide
for more details.

---

[chmouel]

Perhaps update the sample too, to not use master

[divyansh42]

Perhaps update the sample too, to not use master

@chmouel I have checked in the sample for git-clone task, master is not used any where.
Did you mean we need to check for master in every catalog task? Please let me know your thoughts on this.

[vinamra28]

/test pull-tekton-catalog-build-tests

[divyansh42]

/hold

[chmouel]

let's wait for #433 first which would be a 0.2 bump,

[ghost]

#433 is merged now - suggest porting these changes to 0.2. Thanks for taking this on!

[divyansh42]

/hold cancel

[vinamra28]

can we change this also? 🙂

[vinamra28]

/lgtm

[vinamra28]

/cc @vdemeester @chmouel
can we get this in? 🙂

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg, vinamra28

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbwsg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[chmouel]

/lgtm

Looking Good! 🤙🏽

[tekton-robot]

@divyansh42: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-tekton-catalog-integration-tests	76baa49	link	/test pull-tekton-catalog-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[tekton-robot]

@divyansh42: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-tekton-catalog-integration-tests	76baa49	link	/test pull-tekton-catalog-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.