-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix no repeated subjects for v2alpha4 pipelineruns #1130
Fix no repeated subjects for v2alpha4 pipelineruns #1130
Conversation
Hi @renzodavid9. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
e10a5cd
to
22d7ea4
Compare
Thanks for the quick fix @renzodavid9 !! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chitrangpatel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Change the pipelinerun v2alpha4 method that calculates the subjects to use `artifact.AppendSubjects` instead of `append` to avoid duplicated subjects.
22d7ea4
to
dea2e34
Compare
Rebased with latest changes fixing t |
/lgtm |
/kind bug |
Change the pipelinerun v2alpha4 method that calculates the subjects to use `artifact.AppendSubjects` instead of `append` to avoid duplicated subjects. (cherry picked from commit badc734)
Change the pipelinerun v2alpha4 method that calculates the subjects to use `artifact.AppendSubjects` instead of `append` to avoid duplicated subjects. (cherry picked from commit badc734)
* Fix field names in generated json statement (#1129) To keep backwards compatibility with previous struct versions (e.g, github.com/in-toto/in-toto-golang/in_toto) we have to use protojson.Marshal function to transform the struct to its json representation so the tags defined in the intoto.Statement are follow and applied to the resulting string. (cherry picked from commit 3bf8cac) * Fix no repeated subjects for v2alpha4 pipelineruns (#1130) Change the pipelinerun v2alpha4 method that calculates the subjects to use `artifact.AppendSubjects` instead of `append` to avoid duplicated subjects. (cherry picked from commit badc734) * Calculate subjects per formatter (#1132) * Calculate subjects per formatter * Tests for new retrieve full uris in grafeas (cherry picked from commit 750a98e)
Fixes: #1131
Change the pipelinerun v2alpha4 method that calculates the subjects to use
artifact.AppendSubjects
instead ofappend
to avoid duplicated subjects.Changes
Use of
artifact.AppendSubjects
instead ofappend
when calculating subjects withartifacts.pipelinerun.enable-deep-inspection: "true"
for a pipelinerun using v2alpha4 formatter.Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)