TEP 0122 - Adding taskspec to buildConfig and taskrunspec to parameters #663

chitrangpatel · 2023-01-03T16:20:19Z

This PR introduces a new format slsa/v2alpha1 (later switch to slsa/v2) for taskrun provenance which contains complete build instructions as proposed in TEP0122. This is a backwards incompatible change but necessary for completeness of build instructions. While it's in alpha state, it is considered WIP and will undergo multiple upgrades until it is feature complete.

Changes

This PR adds the complete TaskSpec in the buildConfig and TaskRunSpec fields to invocation.Parameters. invocation.Environment section of the provenance will be added in a follow up PR after the feature flags are surfaced in the taskrun status.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Has Docs included if any changes are user facing
Has Tests included if any functionality added or changed
Follows the commit message standard
Meets the Tekton contributor standards (including
functionality, content, code)
Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

complete build instuctions: add taskspec to buildConfig

/kind feature

tekton-robot · 2023-01-03T16:23:49Z

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
pkg/chains/formats/extract/extract.go	Do not exist	41.9%
pkg/chains/formats/intotoite6v2/intotoite6v2.go	Do not exist	87.5%
pkg/chains/formats/intotoite6v2/taskrun/taskrun.go	Do not exist	76.7%

tekton-robot · 2023-01-03T16:34:10Z

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
pkg/chains/formats/extract/extract.go	Do not exist	41.9%
pkg/chains/formats/intotoite6v2/intotoite6v2.go	Do not exist	87.5%
pkg/chains/formats/intotoite6v2/taskrun/taskrun.go	Do not exist	76.7%

bendory

This LGTM, but can you please complete the Submitter Checklist?

wlynch

I'd hold off on the attest/extract package moves for another PR unless we strictly need them to avoid import cycles - they're fairly specific to intoto/slsa so they probably still belong in a intoto/slsa rooted directory.

pkg/chains/formats/all/all.go

pkg/chains/formats/intotoite6v2/intotoite6v2.go

pkg/chains/formats/intotoite6v2/intotoite6v2_test.go

pkg/chains/formats/intotoite6v2/taskrun/taskrun.go

chitrangpatel · 2023-01-17T19:33:44Z

/hold wait for some other PRs to be merged first.

chitrangpatel · 2023-01-23T16:01:28Z

/hold cancel

tekton-robot · 2023-01-23T16:04:39Z

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/chains/formats/slsa/v2/intotoite6v2.go	Do not exist	87.5%
pkg/chains/formats/slsa/v2/taskrun/taskrun.go	Do not exist	32.6%

tekton-robot · 2023-01-23T20:40:50Z

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/chains/formats/slsa/v2/intotoite6v2.go	Do not exist	85.7%
pkg/chains/formats/slsa/v2/taskrun/taskrun.go	Do not exist	60.0%

pkg/chains/formats/slsa/v2/taskrun/taskrun.go

pkg/chains/formats/all/all.go

pkg/chains/formats/slsa/v2/intotoite6v2.go

pkg/chains/formats/all/all.go

pkg/chains/formats/slsa/v2/taskrun/taskrun.go

pkg/chains/formats/slsa/v1/taskrun/material.go

pkg/chains/formats/slsa/v2/intotoite6v2_test.go

tekton-robot · 2023-01-31T18:17:44Z

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/chains/formats/slsa/v2/intotoite6v2.go	Do not exist	85.7%
pkg/chains/formats/slsa/v2/taskrun/taskrun.go	Do not exist	60.0%

tekton-robot · 2023-02-14T17:14:05Z

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
pkg/chains/formats/slsa/internal/material/material.go	Do not exist	84.1%
pkg/chains/formats/slsa/v2/slsav2.go	Do not exist	85.7%
pkg/chains/formats/slsa/v2/taskrun/taskrun.go	Do not exist	60.0%

pkg/chains/formats/slsa/internal/material/material_test.go

tekton-robot · 2023-02-15T19:18:35Z

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
pkg/chains/formats/slsa/internal/material/material.go	Do not exist	84.1%
pkg/chains/formats/slsa/v2/slsav2.go	Do not exist	85.7%
pkg/chains/formats/slsa/v2/taskrun/taskrun.go	Do not exist	60.0%

tekton-robot · 2023-02-15T20:24:34Z

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
pkg/chains/formats/slsa/internal/material/material.go	Do not exist	84.1%
pkg/chains/formats/slsa/v2/slsav2.go	Do not exist	85.7%
pkg/chains/formats/slsa/v2/taskrun/taskrun.go	Do not exist	60.0%

tekton-robot · 2023-02-16T16:58:39Z

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
pkg/chains/formats/slsa/internal/material/material.go	Do not exist	84.1%
pkg/chains/formats/slsa/v2/slsav2.go	Do not exist	85.7%
pkg/chains/formats/slsa/v2/taskrun/taskrun.go	Do not exist	60.0%

This PR introduces a new format `slsa/v2` which contains the complete build instructions as designed in TEP0122. Note that we are currently surfacing it for the users as `slsa/v2alpha1` since it is WIP and will undergo updates until we make it available for pipelineruns as well.

tekton-robot · 2023-02-16T18:19:37Z

The following is the coverage report on the affected files.
Say /test pull-tekton-chains-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage
pkg/chains/formats/slsa/internal/material/material.go	Do not exist	84.1%
pkg/chains/formats/slsa/v2/slsav2.go	Do not exist	85.7%
pkg/chains/formats/slsa/v2/taskrun/taskrun.go	Do not exist	60.0%

wlynch

LGTM! Just one small tweak to the docs and good to merge.

wlynch · 2023-02-16T20:14:08Z

docs/config.md

@@ -51,11 +51,12 @@ Supported keys include:

 | Key | Description | Supported Values | Default |
 | :--- | :--- | :--- | :--- |
-| `artifacts.taskrun.format` | The format to store `TaskRun` payloads in. | `in-toto`, `slsa/v1`| `in-toto` |
+| `artifacts.taskrun.format` | The format to store `TaskRun` payloads in. | `in-toto`, `slsa/v1`, `slsa/v2alpha1`| `in-toto` |


I'd go a step further and remove it from the top level config docs for now and just leave it documented in slsa/README.md.

Sounds good!

wlynch

eh I won't block submission on a 1 line change. I'll send you a PR once this is in.

tekton-robot · 2023-02-16T20:34:06Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bendory, wlynch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [wlynch]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

wlynch · 2023-02-16T20:36:43Z

/lgtm

tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 3, 2023

tekton-robot requested review from lcarva and wlynch January 3, 2023 16:20

tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 3, 2023

chitrangpatel changed the title ~~TEP 0122: complete build instuctions: adding taskspec to buildConfig~~ TEP 0122 - complete build instuctions: adding taskspec to buildConfig Jan 3, 2023

chitrangpatel changed the title ~~TEP 0122 - complete build instuctions: adding taskspec to buildConfig~~ TEP 0122 - complete build instructions: adding taskspec to buildConfig Jan 3, 2023

chitrangpatel force-pushed the slsav2 branch from 7eeae60 to ddc7b5a Compare January 3, 2023 16:30

bendory approved these changes Jan 5, 2023

View reviewed changes

wlynch requested changes Jan 9, 2023

View reviewed changes

tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 9, 2023

tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2023

chitrangpatel force-pushed the slsav2 branch from ddc7b5a to 7daf397 Compare January 23, 2023 16:01

tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 23, 2023

tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 23, 2023

chitrangpatel force-pushed the slsav2 branch from 7daf397 to 82c4f25 Compare January 23, 2023 20:37

tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 23, 2023

chitrangpatel changed the title ~~TEP 0122 - complete build instructions: adding taskspec to buildConfig~~ TEP 0122 - complete build instructions: adding taskspec to buildConfig and taskrunspec to parameters Jan 23, 2023

chitrangpatel changed the title ~~TEP 0122 - complete build instructions: adding taskspec to buildConfig and taskrunspec to parameters~~ TEP 0122 - Adding taskspec to buildConfig and taskrunspec to parameters Jan 23, 2023

chitrangpatel commented Jan 23, 2023

View reviewed changes

pkg/chains/formats/slsa/v2/taskrun/taskrun.go Show resolved Hide resolved

wlynch requested changes Jan 24, 2023

View reviewed changes

tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 27, 2023

chitrangpatel force-pushed the slsav2 branch from 82c4f25 to e0c17ed Compare January 31, 2023 18:12

tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 31, 2023

chitrangpatel mentioned this pull request Feb 2, 2023

Implementation of TEP 0122: Complete Build Instructions for TaskRun #683

Closed

6 tasks

chitrangpatel force-pushed the slsav2 branch from e0c17ed to cf29413 Compare February 14, 2023 17:10

jagathprakash reviewed Feb 15, 2023

View reviewed changes

pkg/chains/formats/slsa/internal/material/material_test.go Show resolved Hide resolved

chitrangpatel force-pushed the slsav2 branch from cf29413 to a808702 Compare February 15, 2023 19:14

chitrangpatel force-pushed the slsav2 branch from a808702 to 781e8be Compare February 15, 2023 20:17

chitrangpatel force-pushed the slsav2 branch from 781e8be to 8afcb13 Compare February 16, 2023 16:50

chitrangpatel force-pushed the slsav2 branch from 8afcb13 to 43ce306 Compare February 16, 2023 18:00

chitrangpatel force-pushed the slsav2 branch from 43ce306 to 3e909af Compare February 16, 2023 18:14

chitrangpatel requested review from wlynch and removed request for lcarva February 16, 2023 20:13

wlynch requested changes Feb 16, 2023

View reviewed changes

wlynch approved these changes Feb 16, 2023

View reviewed changes

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2023

tekton-robot assigned wlynch Feb 16, 2023

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2023

tekton-robot merged commit 3ddd5f4 into tektoncd:main Feb 16, 2023

chitrangpatel mentioned this pull request Mar 28, 2023

Remove TaskRunResults from slsa/v2alpha1 #750

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TEP 0122 - Adding taskspec to buildConfig and taskrunspec to parameters #663

TEP 0122 - Adding taskspec to buildConfig and taskrunspec to parameters #663

chitrangpatel commented Jan 3, 2023 •

edited

Loading

tekton-robot commented Jan 3, 2023

tekton-robot commented Jan 3, 2023

bendory left a comment

wlynch left a comment

chitrangpatel commented Jan 17, 2023

chitrangpatel commented Jan 23, 2023

tekton-robot commented Jan 23, 2023

tekton-robot commented Jan 23, 2023

tekton-robot commented Jan 31, 2023

tekton-robot commented Feb 14, 2023

tekton-robot commented Feb 15, 2023

tekton-robot commented Feb 15, 2023

tekton-robot commented Feb 16, 2023

tekton-robot commented Feb 16, 2023

wlynch left a comment

wlynch Feb 16, 2023

chitrangpatel Feb 16, 2023

wlynch left a comment

tekton-robot commented Feb 16, 2023

wlynch commented Feb 16, 2023

TEP 0122 - Adding taskspec to buildConfig and taskrunspec to parameters #663

TEP 0122 - Adding taskspec to buildConfig and taskrunspec to parameters #663

Conversation

chitrangpatel commented Jan 3, 2023 • edited Loading

Changes

Submitter Checklist

Release Notes

tekton-robot commented Jan 3, 2023

tekton-robot commented Jan 3, 2023

bendory left a comment

Choose a reason for hiding this comment

wlynch left a comment

Choose a reason for hiding this comment

chitrangpatel commented Jan 17, 2023

chitrangpatel commented Jan 23, 2023

tekton-robot commented Jan 23, 2023

tekton-robot commented Jan 23, 2023

tekton-robot commented Jan 31, 2023

tekton-robot commented Feb 14, 2023

tekton-robot commented Feb 15, 2023

tekton-robot commented Feb 15, 2023

tekton-robot commented Feb 16, 2023

tekton-robot commented Feb 16, 2023

wlynch left a comment

Choose a reason for hiding this comment

wlynch Feb 16, 2023

Choose a reason for hiding this comment

chitrangpatel Feb 16, 2023

Choose a reason for hiding this comment

wlynch left a comment

Choose a reason for hiding this comment

tekton-robot commented Feb 16, 2023

wlynch commented Feb 16, 2023

chitrangpatel commented Jan 3, 2023 •

edited

Loading