Fix to prevent adding empty structs into materials. #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/M
jagathprakash
force-pushed
the
empty_material
branch
from
433fa18
to
31f825f
Compare
tekton-robot
added
size/L
|
The following is the coverage report on the affected files.
|
Signed-off-by: jagathprakash <[email protected]>
Thanks for the review. Addressed all comments. |
|
Needs a push? 😅 |
jagathprakash
force-pushed
the
empty_material
branch
from
31f825f
to
349d110
Compare
yes 😬 done 😃 |
|
The following is the coverage report on the affected files.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wlynch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jagathprakash [email protected]
Changes
Prior to this change if there was no CHAINS-GIT_URL or CHAINS-GIT_COMMIT results in PipelineRun object, we would add an empty struct to the materials section of the SLSA provenance.
This fixes this to prevent the addition of the empty structs.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes