Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tekton as a provenance format #685

Merged
merged 1 commit into from
Jan 27, 2023
Merged

Remove tekton as a provenance format #685

merged 1 commit into from
Jan 27, 2023

Conversation

chitrangpatel
Copy link
Contributor

@chitrangpatel chitrangpatel commented Jan 19, 2023 •
edited
Loading

This PR removes tekton as a provenance format since it was deprecated in an earlier release.

Changes

  1. Removes the directory tekton in formats/.
  2. Updates all unit tests to point to in-toto instead of tekton.
  3. Updated default format to in-toto.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Remove tekton from supported provenance formats

/kind feature

@tekton-robot tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 19, 2023
@chitrangpatel
Copy link
Contributor Author

/assign @lcarva

@chitrangpatel
Copy link
Contributor Author

/test pull-tekton-chains-integration-tests

@tekton-robot tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 19, 2023
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 19, 2023
@chitrangpatel chitrangpatel force-pushed the remove-format-tekton branch 7 times, most recently from 111623f to 8e5c7ac Compare January 20, 2023 17:28
wlynch
wlynch approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@wlynch wlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 24, 2023
@wlynch
Copy link
Member

wlynch commented Jan 24, 2023

/lgtm cancel

@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2023
wlynch
wlynch requested changes Jan 24, 2023
View reviewed changes
Copy link
Member

@wlynch wlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs/config.md also needs to be updated.

@tekton-robot tekton-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2023
@chitrangpatel
Remove tekton as a provenance format
dd5db30 
This PR removes tekton as a provenance format since it was
deprecated in an earlier release.
@chitrangpatel chitrangpatel requested review from wlynch and removed request for priyawadhwa and chuangw6 January 24, 2023 16:00
@chitrangpatel
Copy link
Contributor Author

docs/config.md also needs to be updated.

Done!

wlynch
wlynch approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@wlynch wlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2023
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wlynch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2023
@tekton-robot tekton-robot merged commit 5fab3e2 into tektoncd:main Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlynch wlynch wlynch approved these changes

Assignees

@wlynch wlynch

@lcarva lcarva

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chitrangpatel @wlynch @tekton-robot @lcarva