Fix a few tests which failed when run individually

I honestly can't tell how they passed when run as a whole, since in both cases, the underlying `ClusterTask` or `Pipeline` didn't have the expected parameters in their param specs, but hey.

Signed-off-by: Andrew Bayer <[email protected]>

pkg/cmd/clustertask/start_test.go

@@ -223,6 +223,12 @@ func Test_ClusterTask_Start(t *testing.T) {
  },
  },
  },
+ Params: []v1alpha1.ParamSpec{
+ {
+ Name: "myarg",
+ Type: v1alpha1.ParamTypeString,
+ },
+ },
  Steps: []v1alpha1.Step{
  {
  Container: corev1.Container{

pkg/cmd/pipeline/start_test.go

@@ -764,6 +764,8 @@ func TestPipelineStart_ExecuteCommand(t *testing.T) {
  "start", "-f", "./testdata/pipeline-v1alpha1.yaml",
  "-r=source-repo=scaffold-git",
  "-r=web-image=imageres",
+ "-p=pipeline-param=value1",
+ "-p=rev-param=value2",
  "-n", "ns",
  "--dry-run",
  },
@@ -795,6 +797,8 @@ func TestPipelineStart_ExecuteCommand(t *testing.T) {
  "start", "-f", "./testdata/pipeline-v1alpha1.yaml",
  "-r=source-repo=scaffold-git",
  "-r=web-image=imageres",
+ "-p=pipeline-param=value1",
+ "-p=rev-param=value2",
  "-n", "ns",
  },
  namespace: "",

pkg/cmd/pipeline/testdata/TestPipelineStart_ExecuteCommand-Dry_Run_using_--filename_v1alpha1.golden

@@ -5,7 +5,19 @@ metadata:
  generateName: test-pipeline-run-
  namespace: ns
 spec:
+ params:
+ - name: pipeline-param
+ value: value1
+ - name: rev-param
+ value: value2
  pipelineSpec:
+ params:
+ - default: foo
+ name: pipeline-param
+ type: string
+ - default: bar
+ name: rev-param
+ type: string
  resources:
  - name: source-repo
  type: git

pkg/cmd/pipeline/testdata/TestPipelineStart_ExecuteCommand-Dry_Run_with_output=json_-f_v1alpha1.golden

@@ -80,6 +80,18 @@
  }
  ]
  }
+ ],
+ "params": [
+ {
+ "name": "pipeline-param",
+ "type": "string",
+ "default": "foo"
+ },
+ {
+ "name": "rev-param",
+ "type": "string",
+ "default": "bar"
+ }
  ]
  },
  "resources": [

pkg/cmd/pipeline/testdata/pipeline-v1alpha1.yaml

@@ -17,6 +17,13 @@ kind: Pipeline
 metadata:
  name: test-pipeline
 spec:
+ params:
+ - name: pipeline-param
+ type: string
+ default: "foo"
+ - name: rev-param
+ type: string
+ default: "bar"
  resources:
  - name: source-repo
  type: git