Upgrade AlecAivazais/survey to v2.3.5

[abayer]

Changes

I was having trouble debugging some tests I was working on refactoring, and eventually realized this was due to AlecAivazis/survey#408, which was fixed in survey v2.3.3.

This also ends up upgrading hinshun/vt10x, getting rid of the NewVT10xTerminal function we'd been calling in a few places, so I band-aided that by adding an equivalent function in test/helper/helpers.go.

/kind misc

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Run the code checkers with make check
• Regenerate the manpages, docs and go formatting with make generated
• Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

NONE

[abayer]

/assign @vdemeester

[abayer]

Oh great, it fails cross-compiling for Windows!

GOOS=windows GOARCH=amd64 go build -mod=vendor  -o bin/tkn-windows-amd64 ./cmd/tkn
# github.com/hinshun/vt10x
vendor/github.com/hinshun/vt10x/vt_other.go:26:7: t.State.cur.attr undefined (type Cursor has no field or method attr, but does have Attr)
vendor/github.com/hinshun/vt10x/vt_other.go:27:7: t.State.cur.attr undefined (type Cursor has no field or method attr, but does have Attr)
make: *** [Makefile:61: amd64] Error 2

EDIT: Fixed that by bumping hinshun/vt10x to pick up hinshun/vt10x@1ab2cad

[piyush-garg]

/approve

[pradeepitm12]

/lgtm

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: piyush-garg, pradeepitm12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [piyush-garg,pradeepitm12]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[piyush-garg]

/retest