Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEP-0033: Mark as implemented #584

Merged
merged 1 commit into from
Dec 16, 2021
Merged

TEP-0033: Mark as implemented #584

merged 1 commit into from
Dec 16, 2021

Conversation

abayer
Copy link
Contributor

@abayer abayer commented Dec 15, 2021 •
edited
Loading

tektoncd/pipeline#3881 is the "main" PR for this

cc @afrittoli

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 15, 2021
dibyom
dibyom reviewed Dec 15, 2021
View reviewed changes
Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbwsg Should this be implementing or implemented?

@ghost
Copy link

ghost commented Dec 16, 2021

Yeah I'd consider that TEP in its "done" state now - thanks for updating it @abayer! - new flags will continue to be introduced for behaviour deprecations but I think all the machinery is in place. We will at some point need to add enable-api-fields: "stable" but I don't think the specific flag values are blockers to calling the TEP done. implemented sgtm!

@abayer
TEP-0033: Mark as implemented
dd68cdd 
tektoncd/pipeline#3881 is the "main" PR for this

Signed-off-by: Andrew Bayer <[email protected]>
@abayer abayer changed the title TEP-0033: Mark as implementing TEP-0033: Mark as implemented Dec 16, 2021
@abayer
Copy link
Contributor Author

abayer commented Dec 16, 2021

@sbwsg Updated!

@ghost
Copy link

ghost commented Dec 16, 2021

/lgtm

@tekton-robot tekton-robot assigned ghost Dec 16, 2021
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2021
jerop
jerop approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @abayer

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2021
@tekton-robot tekton-robot merged commit 93ad960 into tektoncd:main Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibyom dibyom dibyom left review comments

@jerop jerop jerop approved these changes

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abayer @tekton-robot @dibyom @jerop