Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trusted Tasks PoC #834

Closed
wlynch opened this issue Feb 23, 2022 · 10 comments
Closed

Trusted Tasks PoC #834

wlynch opened this issue Feb 23, 2022 · 10 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@wlynch
Copy link
Member

wlynch commented Feb 23, 2022

Feature request

We're planning on creating a new sub-directory to prototype a trusted tasks admission controller. This is originally inspired by @squee1945's original TEP tektoncd/community#537.

To start, our plan is to prototype an admission controller with annotation based signatures before reopening a TEP for any Pipeline API changes.

A lot of this work/design is still TBD, but creating this issue to track and have a place for discussion.
In progress design doc (still very rough): https://hackmd.io/93mfJPyDQKCyn0IKwjzgWQ

/cc @Yongxuanzhang

Use case

Same motivation as tektoncd/community#537 - implement a mechanism to trust task content in order to have more trust in what is being executed + task results that are being returned (i.e. how can we have more trust that the git task is actually doing git things?)

@wlynch wlynch added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 23, 2022
@wlynch
Copy link
Member Author

wlynch commented Feb 23, 2022

@lukehinds @nadgowdas It was pointed out to us that this idea is really similar to your work in https:/OpenSecureSupplyChain/tkn-admcontroller

I still need to dig into that repo a bit more, but would love to hear any thoughts / feedback / things to watch out for from your prototyping.

@lukehinds
Copy link

@wlynch I don't think we got to far with that, but I would say borrow what you need. I seem to recall @nadgowdas had a TEP open as well.

Good to see this underway, I will share with the sigstore community to see if others would like to help

@nadgowdas
Copy link

thanks for connecting @wlynch. We also had some discussion with Jim Bugwadia from Kyverno to see if such enforcement can be applied through kyverno policies. I had collected some thoughts in this doc: https://docs.google.com/document/d/1r2M9jVcL7fs7Edyzr30fV8pcVhxKUkgSmrFNuTXNKtg/edit?usp=sharing

If you have any thoughts let us know.

@bobcatfish
Copy link
Contributor

sgtm!

@tektoncd/governing-board - need at least one other approval

@nadgowdas is there a group I need to join to get access to the doc?

p.s. re Kyverno, an important requirement for a solution in Tekton would be that it was compatible with mulitple policy engines and that we avoided coupling Tekton to any solution in particular (there has been some discussion around this in TEP-0035 in the conteext of applying security policies as a whole)

@nadgowdas
Copy link

@bobcatfish I completely agree with you to have such admission checks generic and not tied to one solution.
between, I've marked the doc public, it should be accessible to everyone now. (doc link)

@vdemeester
Copy link
Member

sgtm too ! (count this as an approval 😛 )

wlynch added a commit to wlynch/experimental that referenced this issue Mar 2, 2022
Initial directory creation with initial OWNERS file. Proposed and
approved in tektoncd#834
wlynch added a commit to wlynch/experimental that referenced this issue Mar 2, 2022
Initial directory creation with initial OWNERS file. Proposed and
approved in tektoncd#834
wlynch added a commit to wlynch/experimental that referenced this issue Mar 2, 2022
Initial directory creation with initial OWNERS file. Proposed and
approved in tektoncd#834
tekton-robot pushed a commit that referenced this issue Mar 2, 2022
Initial directory creation with initial OWNERS file. Proposed and
approved in #834
@tekton-robot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 29, 2022
@tekton-robot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 28, 2022
@tekton-robot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

6 participants