Remove /builder/home mount

Users should migrate to the new path, /tekton/home, or (better yet) only rely on the value of $HOME (which was previously moved to /tekton/home)
tektoncd · Dec 9, 2019 · 449cf1b · 449cf1b
1 parent efbcf9d
commit 449cf1b
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 48 deletions.
diff --git a/examples/taskruns/old-home-volume.yaml b/examples/taskruns/old-home-volume.yaml
diff --git a/pkg/pod/pod.go b/pkg/pod/pod.go
@@ -32,7 +32,6 @@ import (
 const (
  workspaceDir = "/workspace"
  homeDir = "/tekton/home"
- oldHomeDir = "/builder/home"
 
  taskRunLabelKey = pipeline.GroupName + pipeline.TaskRunLabelKey
  ManagedByLabelKey = "app.kubernetes.io/managed-by"
@@ -57,12 +56,6 @@ var (
  }, {
  Name: "tekton-home",
  MountPath: homeDir,
- }, {
- // Mount the home Volume to both /tekton/home and (old,
- // deprecated) /builder/home.
- // TODO(#1633): After v0.10, we can remove this old path.
- Name: "tekton-home",
- MountPath: oldHomeDir,
  }}
  implicitVolumes = []corev1.Volume{{
  Name: "workspace",

diff --git a/pkg/reconciler/taskrun/taskrun_test.go b/pkg/reconciler/taskrun/taskrun_test.go
@@ -210,7 +210,6 @@ var (
  tb.VolumeMount("downward", "/tekton/downward"),
  tb.VolumeMount("workspace", workspaceDir),
  tb.VolumeMount("tekton-home", "/tekton/home"),
- tb.VolumeMount("tekton-home", "/builder/home"),
  }
 
  actualOps = append(actualOps, ops...)
@@ -309,7 +308,6 @@ func TestReconcile_ExplicitDefaultSA(t *testing.T) {
  tb.VolumeMount("downward", "/tekton/downward"),
  tb.VolumeMount("workspace", workspaceDir),
  tb.VolumeMount("tekton-home", "/tekton/home"),
- tb.VolumeMount("tekton-home", "/builder/home"),
  ),
  ),
  ),
@@ -344,7 +342,6 @@ func TestReconcile_ExplicitDefaultSA(t *testing.T) {
  tb.VolumeMount("downward", "/tekton/downward"),
  tb.VolumeMount("workspace", workspaceDir),
  tb.VolumeMount("tekton-home", "/tekton/home"),
- tb.VolumeMount("tekton-home", "/builder/home"),
  ),
  ),
  ),
@@ -562,7 +559,6 @@ func TestReconcile(t *testing.T) {
  tb.VolumeMount("downward", "/tekton/downward"),
  tb.VolumeMount("workspace", workspaceDir),
  tb.VolumeMount("tekton-home", "/tekton/home"),
- tb.VolumeMount("tekton-home", "/builder/home"),
  ),
  ),
  ),
@@ -597,7 +593,6 @@ func TestReconcile(t *testing.T) {
  tb.VolumeMount("downward", "/tekton/downward"),
  tb.VolumeMount("workspace", workspaceDir),
  tb.VolumeMount("tekton-home", "/tekton/home"),
- tb.VolumeMount("tekton-home", "/builder/home"),
  ),
  ),
  ),
@@ -637,7 +632,6 @@ func TestReconcile(t *testing.T) {
  tb.VolumeMount("tools", "/tekton/tools"),
  tb.VolumeMount("workspace", workspaceDir),
  tb.VolumeMount("tekton-home", "/tekton/home"),
- tb.VolumeMount("tekton-home", "/builder/home"),
  ),
  tb.PodContainer("step-mycontainer", "myimage",
  tb.Command(entrypointLocation),
@@ -649,7 +643,6 @@ func TestReconcile(t *testing.T) {
  tb.VolumeMount("tools", "/tekton/tools"),
  tb.VolumeMount("workspace", workspaceDir),
  tb.VolumeMount("tekton-home", "/tekton/home"),
- tb.VolumeMount("tekton-home", "/builder/home"),
  ),
  tb.PodContainer("step-myothercontainer", "myotherimage",
  tb.Command(entrypointLocation),
@@ -660,7 +653,6 @@ func TestReconcile(t *testing.T) {
  tb.VolumeMount("tools", "/tekton/tools"),
  tb.VolumeMount("workspace", workspaceDir),
  tb.VolumeMount("tekton-home", "/tekton/home"),
- tb.VolumeMount("tekton-home", "/builder/home"),
  ),
  tb.PodContainer("step-image-digest-exporter-9l9zj", "override-with-imagedigest-exporter-image:latest",
  tb.Command(entrypointLocation),
@@ -671,7 +663,6 @@ func TestReconcile(t *testing.T) {
  tb.VolumeMount("tools", "/tekton/tools"),
  tb.VolumeMount("workspace", workspaceDir),
  tb.VolumeMount("tekton-home", "/tekton/home"),
- tb.VolumeMount("tekton-home", "/builder/home"),
  tb.TerminationMessagePolicy(corev1.TerminationMessageFallbackToLogsOnError),
  ),
  ),
@@ -712,7 +703,6 @@ func TestReconcile(t *testing.T) {
  tb.VolumeMount("downward", "/tekton/downward"),
  tb.VolumeMount("workspace", workspaceDir),
  tb.VolumeMount("tekton-home", "/tekton/home"),
- tb.VolumeMount("tekton-home", "/builder/home"),
  ),
  tb.PodContainer("step-mycontainer", "myimage",
  tb.Command(entrypointLocation),
@@ -723,7 +713,6 @@ func TestReconcile(t *testing.T) {
  tb.VolumeMount("tools", "/tekton/tools"),
  tb.VolumeMount("workspace", workspaceDir),
  tb.VolumeMount("tekton-home", "/tekton/home"),
- tb.VolumeMount("tekton-home", "/builder/home"),
  ),
  ),
  ),
@@ -757,7 +746,6 @@ func TestReconcile(t *testing.T) {
  tb.VolumeMount("downward", "/tekton/downward"),
  tb.VolumeMount("workspace", workspaceDir),
  tb.VolumeMount("tekton-home", "/tekton/home"),
- tb.VolumeMount("tekton-home", "/builder/home"),
  ),
  ),
  ),
@@ -796,7 +784,6 @@ func TestReconcile(t *testing.T) {
  tb.VolumeMount("downward", "/tekton/downward"),
  tb.VolumeMount("workspace", workspaceDir),
  tb.VolumeMount("tekton-home", "/tekton/home"),
- tb.VolumeMount("tekton-home", "/builder/home"),
  ),
  tb.PodContainer("step-mystep", "ubuntu",
  tb.Command(entrypointLocation),
@@ -806,7 +793,6 @@ func TestReconcile(t *testing.T) {
  tb.VolumeMount("tools", "/tekton/tools"),
  tb.VolumeMount("workspace", workspaceDir),
  tb.VolumeMount("tekton-home", "/tekton/home"),
- tb.VolumeMount("tekton-home", "/builder/home"),
  ),
  ),
  ),
@@ -839,7 +825,6 @@ func TestReconcile(t *testing.T) {
  tb.VolumeMount("downward", "/tekton/downward"),
  tb.VolumeMount("workspace", workspaceDir),
  tb.VolumeMount("tekton-home", "/tekton/home"),
- tb.VolumeMount("tekton-home", "/builder/home"),
  ),
  ),
  ),