Emit event only once

When finishReconcileUpdateEmitEvents was introduced in PR #2805,
I forgot to remove one of the original event.Emit, so one event
was sent twice. The fake recorder sometimes probably recognised
the duplicate and filtered it out, causing flackiness in tests,
as unit tests expect a fixed number of events.

Thanks @GregDritschler for troubleshooting this!

Fixes: #2857

pkg/reconciler/pipelinerun/pipelinerun.go

@@ -440,7 +440,6 @@ func (c *Reconciler) reconcile(ctx context.Context, pr *v1beta1.PipelineRun) err
  }
  }
 
- before := pr.Status.GetCondition(apis.ConditionSucceeded)
  after := resources.GetPipelineConditionStatus(pr, pipelineState, logger, d)
  switch after.Status {
  case corev1.ConditionTrue:
@@ -452,8 +451,6 @@ func (c *Reconciler) reconcile(ctx context.Context, pr *v1beta1.PipelineRun) err
  }
  // Read the condition the way it was set by the Mark* helpers
  after = pr.Status.GetCondition(apis.ConditionSucceeded)
- events.Emit(recorder, before, after, pr)
-
  pr.Status.TaskRuns = getTaskRunsStatus(pr, pipelineState)
  logger.Infof("PipelineRun %s status is being set to %s", pr.Name, after)
  return nil