Skip to content

Commit

Permalink
Add the imageID for each step to the TaskRun.Spec.Status object.
Browse files Browse the repository at this point in the history
This allows users to trace the exact steps (including digest) used in each TaskRun.
This information is already available on a Pod, but we need to assume completed Pods
will be GC'ed and not available long after the run is complete.
  • Loading branch information
dlorenc committed Jun 27, 2019
1 parent 9f31820 commit c50ad3e
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
3 changes: 2 additions & 1 deletion pkg/apis/pipeline/v1alpha1/taskrun_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,8 @@ func (tr *TaskRunStatus) SetCondition(newCond *apis.Condition) {
// StepState reports the results of running a step in the Task.
type StepState struct {
corev1.ContainerState
Name string `json:"name,omitempty"`
Name string `json:"name,omitempty"`
ImageID string `json:"imageID,omitempty"`
}

// +genclient
Expand Down
1 change: 1 addition & 0 deletions pkg/status/taskrunpod.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ func UpdateStatusFromPod(taskRun *v1alpha1.TaskRun, pod *corev1.Pod, resourceLis
taskRun.Status.Steps = append(taskRun.Status.Steps, v1alpha1.StepState{
ContainerState: *s.State.DeepCopy(),
Name: resources.TrimContainerNamePrefix(s.Name),
ImageID: s.ImageID,
})
}
}
Expand Down
3 changes: 2 additions & 1 deletion pkg/status/taskrunpod_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,8 @@ func TestUpdateStatusFromPod(t *testing.T) {
Terminated: &corev1.ContainerStateTerminated{
ExitCode: 123,
}},
Name: "state-name",
Name: "state-name",
ImageID: "image-id",
}},
},
}, {
Expand Down

0 comments on commit c50ad3e

Please sign in to comment.