Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure the webhook is always registered before allowing user to create resources #1113

Closed
vdemeester opened this issue Jul 23, 2019 · 4 comments · Fixed by #1894
Closed

Make sure the webhook is always registered before allowing user to create resources #1113

vdemeester opened this issue Jul 23, 2019 · 4 comments · Fixed by #1894
Assignees
@vdemeester
Labels
kind/feature Categorizes issue or PR as related to a new feature. kind/question Issues or PRs that are questions around the project or a particular feature priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
Pipelines 0.11 🐱

Comments

@vdemeester
Copy link
Member

As of today, knative/pkg's code is the one responsible to register the webhook on kubernetes. This means, the following are possible :

  • The webhook fails to start (for any reason), it does not get registered, thus it's not applied
  • The webhook takes time to start (slow network, …), it's not registered quickly enough, a user can create resources

In all those cases, the user can end up creating resources that are either not valid or not mutated (with defaults values)

There is two way to fix these cases:

  1. Move the webhook registration in the yamls, so that the webhook is registered as soon as the CRDs are created, before it started, and thus it will fail if the webhook is not running
  2. Having the controller validate

I have a very very high preference for solution 1. .
@vdemeester vdemeester added kind/feature Categorizes issue or PR as related to a new feature. kind/question Issues or PRs that are questions around the project or a particular feature priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jul 23, 2019
@vdemeester vdemeester added this to the Pipelines 0.6 🐱 milestone Jul 23, 2019
@vdemeester
Copy link
Member Author

/assign

@vdemeester vdemeester mentioned this issue Oct 4, 2019
Closed
@bobcatfish bobcatfish removed this from the Pipelines 0.9 🐱 milestone Nov 25, 2019
@bobcatfish
Copy link
Collaborator

@vdemeester are you still working on this or should we throw it in the backlog instead?

@bobcatfish bobcatfish added this to the Pipelines 1.1 / Post-beta 🐱 milestone Jan 9, 2020
@bobcatfish
Copy link
Collaborator

Throwin it in the backlog 😎 But I added it to the "post beta" milestone so we won't forget it!

@vdemeester vdemeester modified the milestones: Pipelines 1.1 / Post-beta 🐱, Pipelines 1.0/beta 🐱 (0.11) Jan 21, 2020
@vdemeester
Copy link
Member Author

Moving into next release, #1894 with some knative.dev/pkg will fix this I think

/assign

@vdemeester vdemeester mentioned this issue Jan 29, 2020
Merged
3 tasks
@disposab1e disposab1e mentioned this issue Mar 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vdemeester vdemeester

Labels
kind/feature Categorizes issue or PR as related to a new feature. kind/question Issues or PRs that are questions around the project or a particular feature priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
Pipelines 0.11 🐱
Development

Successfully merging a pull request may close this issue.

Bump kubernetes to 1.16.5 and knative/pkg to release-0.12 vdemeester/tektoncd-pipeline
4 participants
@vdemeester @bobcatfish @afrittoli @dibyom