Allowing for actions to be taken in failure scenarios

[bobcatfish]

I'm creating this as an Epic to generally cover being able to express behaviour that should occur in a Pipeline when some part of the Pipeline fails. At the moment we have Conditions in Pipelines, but afaik you can't express "if previous Task failed" as of yet b/c a Task failing will halt execution (correct me if I'm wrong @dibyom !).

And if a Task fails, any PipelineResource output actions that would have occurred will not happen (see #1149).

[vdemeester]

Allowing for actions to be taken in failure scenarios, we should support this with Resources or without, so having a way to say "this step needs to be run even if the previous step failed".

[bobcatfish]

I think @dibyom expressed a desire to work on this :D 🤞

[vdemeester]

Should #1684 and this issue be the same ? (or #1684 be one item of this epic?)

[ghost]

We should aim to get this functionality (in some form...) into 0.11, prior to the beta release going out. This is so that people can give it a try and we can work out any bad wrinkles before the beta is cut.

[dibyom]

Should #1684 and this issue be the same ? (or #1684 be one item of this epic?)

#1684 is one item in this epic

[bobcatfish]

Removed from milestone - @dibyom to create follow up issues for the work to implement the design :D

[gpaul]

I read through the comments and the design doc and I can't find a mention of how timeouts are handled.

My use case: I want to (a) collect task artifacts and (b) report status to github, using Finally tasks. One common reason for pipeline failure is timeout. In the case of a PipelineRun timing out, I would like to do both (a) and (b) once the individual non-final tasks have been stopped.

[gpaul]

Ping?

The design doc says:

Similarly, final tasks can be configured to time out and follow the same default as standard tasks. Default Task and Pipeline Timeout is 60 minutes, documented here.

I'm still not clear: will my final task run if my pipelinerun times out after 1h?

[tekton-robot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

[tekton-robot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

[tekton-robot]

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[bobcatfish]

As mentioned in #1684: I feel like it's fair to consider this closed now that we have finally, tho there are more features to add, and to get the complete set of flexibility someone might want, i think we need to add in #2134 as well