Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task Ouputs examples in the docs looks wrong #1458

Closed
eddycharly opened this issue Oct 23, 2019 · 2 comments · Fixed by #1492
Closed

Task Ouputs examples in the docs looks wrong #1458

eddycharly opened this issue Oct 23, 2019 · 2 comments · Fixed by #1492

Comments

@eddycharly
Copy link
Member

In docs/tasks.md, in the examples about Outputs, we can see things like this :

resources:
  outputs:
    name: storage-gcs
    type: gcs
....

I'm new to tekton and from my understanding it's not the correct syntax.
Shouldn't it be something like this instead ?

outputs:
  resources:
    name: storage-gcs
    type: gcs
....

Also, i'm trying to use a git repository as input, perform some parckage install in it (composer install for instance) and use the result as output.
My task works well, but the output is empty, any example on the syntax to achieve something like this would be great as it's something pretty common.

@eddycharly
Copy link
Member Author

Am i supposed to copy the content from input (the git resource) to the output (same git resource) manually or is there a mechanism that can handle that automatically ?

dlorenc added a commit to dlorenc/build-pipeline that referenced this issue Oct 29, 2019
The docs had task output/resources swapped in a few places. This
corrects them, and fixes tektoncd#1458
tekton-robot pushed a commit that referenced this issue Oct 29, 2019
The docs had task output/resources swapped in a few places. This
corrects them, and fixes #1458
@bobcatfish
Copy link
Collaborator

Even more evidence in support of #1185 :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants