Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Cloud Events SDK changes things significantly #2240

Closed
mattmoor opened this issue Mar 18, 2020 · 5 comments · Fixed by #2243
Closed

New Cloud Events SDK changes things significantly #2240

mattmoor opened this issue Mar 18, 2020 · 5 comments · Fixed by #2243
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@mattmoor
Copy link
Member

Just wanted to give a heads up that the new Cloud Events SDK (v2.0.0-preview3) has significant changes that need to be picked up.

The simplest migration is likely to pick up the new version, and rewrite the current import paths to be rooted at github.com/cloudevents/sdk-go/legacy, which contains the older client. Then the new client can be picked up incrementally.

I looked into doing precisely this, but I wasn't smart enough to get go mod to work with some simple tinkering, so I wanted to at least open this to track.

cc @vdemeester @n3wscott

@n3wscott
Copy link
Contributor

I will look into making go mod work, there might be some things I need to do to allow pulling the preview release. We will be doing an RC in the next couple weeks as we get closer to 2.0.0

@vdemeester
Copy link
Member

/cc @afrittoli
/kind cleanup

@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 18, 2020
@n3wscott
Copy link
Contributor

I have cut a release called v2.0.0-preview4 that does work with go mod today.

@mattmoor
Copy link
Member Author

I may try to give this a shot

@mattmoor
Copy link
Member Author

@n3wscott have you bumped eventing contrib? Looks like they need to bump that to pull in the new CE lib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants