Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Task to update GitHub PR status #535

Closed
bobcatfish opened this issue Feb 21, 2019 · 2 comments
Closed

Create Task to update GitHub PR status #535

bobcatfish opened this issue Feb 21, 2019 · 2 comments
Labels
area/yamls This issue involves writing a lot of yaml design This task is about creating and discussing a design

Comments

@bobcatfish
Copy link
Collaborator

bobcatfish commented Feb 21, 2019

Expected Behavior

We should be testing and releasing Pipelines with Pipelines.

To do this, we need a Task that knows how to update a GitHub PR with the results of a check.

  • Update a PR with the result of the "check", i.e.:

image

The Task

  • Inputs:
    • git repo (maybe? this is a github thing tho)
    • some kind of new resource(s) that contains:
      • github endpoint details
        • PR to update the checks of
        • The check to update
        • What status to update
        • Link to details

Will need to look more into what needs to be specified to update a check, possibly investigate prow's implementation

Actual Behavior

prow does this for us, not sure how.

Additional Info

  • Actually triggering this is not in scope for this issue, it's fine to test manually (we'll be linking these together in a later issue)
  • We're going to need a service account that can update GitHub PR checks
  • This can be considered a POC for "notifications" (Design: Notifications #49) (+ @dlorenc )
@bobcatfish bobcatfish added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. design This task is about creating and discussing a design area/yamls This issue involves writing a lot of yaml and removed help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Feb 21, 2019
@bobcatfish bobcatfish added okr This is for some internal Google project tracking and removed okr This is for some internal Google project tracking labels Feb 21, 2019
@dlorenc
Copy link
Contributor

dlorenc commented Apr 23, 2019

Ref #778

@bobcatfish
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/yamls This issue involves writing a lot of yaml design This task is about creating and discussing a design
Projects
None yet
Development

No branches or pull requests

2 participants