Display last updated time for Tasks, Pipelines, Resources

[imjasonh]

Expected Behavior

After updating a Task, Pipeline or Resource definition, kubectl get pipeline my-pipeline should give some indication of when it was last updated.

Actual Behavior

Instead, it only displays the resource's age (time since creation), which is somewhat less helpful.

$ kubectl get pipeline my-pipeline
NAME            AGE
my-pipeline     14h

Steps to Reproduce the Problem

1. Define a Task, Pipeline, Resource
2. Update it
3. kubectl get it

Additional Info

TaskRuns and PipelineRuns have a lastTransitionTime in its .Status.Conditions, which is configured to be displayed in kubectl output.

It probably makes sense for Pipelines, etc., to define Conditions too, which will give it a lastTransitionTime which I believe will be automatically updated by knative/pkg internals, and which might be useful in the future.

This also enables users to list resources sorted by last update time, or to only show recently-updated resources, etc.

cc @skim1420

[nikhil-thomas]

/assign @nikhil-thomas

[tekton-robot]

@nikhil-thomas: GitHub didn't allow me to assign the following users: nikhil-thomas.

Note that only tektoncd members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign @nikhil-thomas

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[bobcatfish]

@nikhil-thomas let me know if you want to be added to the tektoncd org and you can be assigned for real! (but either way we'll consider it assigned to you :) )

[nikhil-thomas]

@bobcatfish Thank you for adding me 👍

[nikhil-thomas]

/assign @nikhil-thomas

[piyush-garg]

/assign

[bobcatfish]

@piyush-garg are you still working on this?

[piyush-garg]

@bobcatfish Yaa, I am working on this. Sorry for the delay.

@imjasonh The solution you suggested is to use Conditions. But I see the status for Pipeline or Task is deprecated. Should I use Conditions in Spec? or I remove the deprecation? or any other suggestions?

There is this issue kubernetes/kubernetes#12430 for adding the field in ObjectMeta

cc @vdemeester @hrishin

[vdemeester]

ah good point, we remove those Status field because they weren't used at all 🤔
We may need to un-deprecated those… I'm interested in "which I believe will be automatically updated by knative/pkg internals, and which might be useful in the future" part 👼

[JoaoVitoGomes]

Can this be worked on? I'm looking for a first issue to take on.

[vdemeester]

Of course 😉 You can do /assign to assign yourself to issue you are working on.

/assign @AhmaudArbery

[tekton-robot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

[tekton-robot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

[tekton-robot]

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vdemeester]

/remove-lifecycle rotten
/remove-lifecycle stale
/reopen

[tekton-robot]

@vdemeester: Reopened this issue.

In response to this:

/remove-lifecycle rotten
/remove-lifecycle stale
/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[bobcatfish]

@AhmaudArbery and @JoaoVitoGomesa are you still working on this one?

[JoaoVitoGomes]

No feel free to remove me

…

On Tue, Sep 1, 2020, 3:18 PM Christie Wilson ***@***.***> wrote: @AhmaudArbery and @JoaoVitoGomesa are you still working on this one? — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#733 (comment)>, or unsubscribe <https:/notifications/unsubscribe-auth/AA2GCMS2YDOH7PFVBX4TUUTSDVJKTANCNFSM4HD4AXIA> .

[piyush-garg]

@bobcatfish I would like to work on this. I will need some time to look at the possible solutions now. Or do you have something in mind that can be done for this? Outcomes from my previous try #733 (comment)

[piyush-garg]

@bobcatfish @vdemeester @imjasonh

The last updation time can be retrieved from metadata.managedFields also. But this is an array and for every different method, it does add an element to array like kubectl, oc, controller and each have their own last updated time.

[tekton-robot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

[tekton-robot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

[tekton-robot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

[tekton-robot]

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.