Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove containerTemplate in favor of stepTemplate #977

Closed
bobcatfish opened this issue Jun 11, 2019 · 0 comments · Fixed by #1174
Closed

Remove containerTemplate in favor of stepTemplate #977

bobcatfish opened this issue Jun 11, 2019 · 0 comments · Fixed by #1174
Assignees
@bobcatfish
Labels
maybe-next-milestone For consideration when planning the next milestone
Milestone
Pipelines 0.6 🐱

Comments

@bobcatfish
Copy link
Collaborator

In #931 we introduced stepTemplate to replace containerTemplate. We want to make this change first in a backwards compatible manner by supporting both. This issue should wait until #931 has been released (probably in 0.5), and in the next version (probably 0.6) we can make the backwards incompatible change.
@bobcatfish bobcatfish added the maybe-next-milestone For consideration when planning the next milestone label Jun 11, 2019
@bobcatfish bobcatfish mentioned this issue Jun 11, 2019
Merged
3 tasks
bobcatfish added a commit to bobcatfish/pipeline that referenced this issue Jun 11, 2019
@bobcatfish
Rename containerTemplate to stepTemplate but support both 👠
ab7669f 
We used the term `containerTemplate` for this template b/c it is a
template of the containers used for each step - however we don't refer
to those as containers, we refer to them as steps, so I think calling
this `stepTemplate` makes slightly more sense and makes the relationship
between this template + the steps a bit more obvious.

This change is backward compatible b/c both `containerTemplate` and
`stepTemplate` will be supported until tektoncd#977 where we will make the
backward incompatible change and remove `containerTemplate`.
bobcatfish added a commit to bobcatfish/pipeline that referenced this issue Jun 11, 2019
@bobcatfish
Rename containerTemplate to stepTemplate but support both 👠
2cdae6c 
We used the term `containerTemplate` for this template b/c it is a
template of the containers used for each step - however we don't refer
to those as containers, we refer to them as steps, so I think calling
this `stepTemplate` makes slightly more sense and makes the relationship
between this template + the steps a bit more obvious.

This change is backward compatible b/c both `containerTemplate` and
`stepTemplate` will be supported until tektoncd#977 where we will make the
backward incompatible change and remove `containerTemplate`.
bobcatfish added a commit to bobcatfish/pipeline that referenced this issue Jun 11, 2019
@bobcatfish
Rename containerTemplate to stepTemplate but support both 👠
cff8c8e 
We used the term `containerTemplate` for this template b/c it is a
template of the containers used for each step - however we don't refer
to those as containers, we refer to them as steps, so I think calling
this `stepTemplate` makes slightly more sense and makes the relationship
between this template + the steps a bit more obvious.

This change is backward compatible b/c both `containerTemplate` and
`stepTemplate` will be supported until tektoncd#977 where we will make the
backward incompatible change and remove `containerTemplate`.
bobcatfish added a commit to bobcatfish/pipeline that referenced this issue Jun 27, 2019
@bobcatfish
Rename containerTemplate to stepTemplate but support both 👠
2765807 
We used the term `containerTemplate` for this template b/c it is a
template of the containers used for each step - however we don't refer
to those as containers, we refer to them as steps, so I think calling
this `stepTemplate` makes slightly more sense and makes the relationship
between this template + the steps a bit more obvious.

This change is backward compatible b/c both `containerTemplate` and
`stepTemplate` will be supported until tektoncd#977 where we will make the
backward incompatible change and remove `containerTemplate`.
tekton-robot pushed a commit that referenced this issue Jun 28, 2019
@bobcatfish @tekton-robot
Rename containerTemplate to stepTemplate but support both 👠
aea3060 
We used the term `containerTemplate` for this template b/c it is a
template of the containers used for each step - however we don't refer
to those as containers, we refer to them as steps, so I think calling
this `stepTemplate` makes slightly more sense and makes the relationship
between this template + the steps a bit more obvious.

This change is backward compatible b/c both `containerTemplate` and
`stepTemplate` will be supported until #977 where we will make the
backward incompatible change and remove `containerTemplate`.
@bobcatfish bobcatfish added this to the Pipelines 0.6 🐱 milestone Aug 6, 2019
@bobcatfish bobcatfish self-assigned this Aug 7, 2019
bobcatfish added a commit to bobcatfish/pipeline that referenced this issue Aug 7, 2019
@bobcatfish
Remove containerTemplate (now called stepTemplate) 👠
1d527ec 
In tektoncd#931 we added `stepTemplate` in addition to `containerTemplate` and
this chagne went out with 0.5. In this release we can now remove
containerTemplate completely.

Fixes tektoncd#977
@bobcatfish bobcatfish mentioned this issue Aug 7, 2019
Merged
3 tasks
tekton-robot pushed a commit that referenced this issue Aug 8, 2019
@bobcatfish @tekton-robot
Remove containerTemplate (now called stepTemplate) 👠
bb85571 
In #931 we added `stepTemplate` in addition to `containerTemplate` and
this chagne went out with 0.5. In this release we can now remove
containerTemplate completely.

Fixes #977
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bobcatfish bobcatfish

Labels
maybe-next-milestone For consideration when planning the next milestone
Projects
None yet
Milestone
Pipelines 0.6 🐱
Development

Successfully merging a pull request may close this issue.

Remove containerTemplate (now called stepTemplate) 👠 bobcatfish/pipeline
1 participant
@bobcatfish