Add validation of embedded TaskSpec in a TaskRun

[vdemeester]

Changes

If a TaskRun embeddeds a Task spec (using taskSpec instead of
taskRef) we should validate the TaskSpec too.

/cc @bobcatfish

Signed-off-by: Vincent Demeester [email protected]

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide for more details.

Double check this list of stuff that's easy to miss:

• If you are adding a new binary/image to the cmd dir, please update
  the release Task and TaskRun to build and release this image

Release Notes

Validates the embedded TaskSpec of a TaskRun

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vdemeester]

Ah the failure will go away with #1081 in 👼 I'll rebase once merged

[bobcatfish]

Hahaha so much validation that we weren't calling! ( cc @EliZucker XD) Probably at least a bit my fault for being so unit test focused :D

@vdemeester can we add some test coverage as well?

[vdemeester]

@vdemeester can we add some test coverage as well?

Yes definitely 👼 But I face a interesting failure though : admission webhook "webhook.tekton.dev" denied the request: mutation failed: invalid value "": taskspec.steps.name 😹

[bobcatfish]

o boy

[vdemeester]

Fixed 🎉 It also fixes support for unnamed steps 😅

[dibyom]

Great find @vdemeester !

/lgtm

[EliZucker]

Oh yeah this is super similar to #1074! /lgtm