Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move nopImage and entrypointImage from pkg/… package to cmd/controller #1348

Merged
merged 2 commits into from
Oct 2, 2019
Merged

Move nopImage and entrypointImage from pkg/… package to cmd/controller #1348

merged 2 commits into from
Oct 2, 2019

Commits on Oct 2, 2019

  1. Move nopImage from pkg/…/sidecars package to cmd/controller 

    This is part of a set of changes to make sure we don't define CLI
flags in our `pkg/…` packages… so that importing packages from there
do not pollute the cli flags.

Signed-off-by: Vincent Demeester <[email protected]>
    @vdemeester
    vdemeester committed Oct 2, 2019
    Configuration menu
    Copy the full SHA
    5e9dded View commit details
    Browse the repository at this point in the history

  2. Move entrypointImage from pkg/…/entrypoint package to cmd/controller 

    This is part of a set of changes to make sure we don't define CLI
flags in our `pkg/…` packages… so that importing packages from there
do not pollute the cli flags.

Signed-off-by: Vincent Demeester <[email protected]>
    @vdemeester
    vdemeester committed Oct 2, 2019
    Configuration menu
    Copy the full SHA
    7a85628 View commit details
    Browse the repository at this point in the history