Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Resource result output, and add support for Git resources. #1424

Merged
merged 1 commit into from
Oct 17, 2019
Merged

Refactor Resource result output, and add support for Git resources. #1424

merged 1 commit into from
Oct 17, 2019

Commits on Oct 17, 2019

  1. Refactor Resource result output, and add support for Git resources. 

    This change builds upon tektoncd#1406, and logs the exact Git commit used by a Git input
to the ResourceResults field.

Some other cleanups are included:
- Removing custom TerminationMessagePath from the Image resource. The default is fine.
- Test cleanup.
- A new helper to write termination messages from resource containers.

And finally, this adds a new environment variable to the git resource steps, indicating the
name of the resource instance they are running as. We should make this more generic and apply
it to all resource steps as part of the extensiblity refactor.
    @dlorenc
    dlorenc committed Oct 17, 2019
    Configuration menu
    Copy the full SHA
    59617fa View commit details
    Browse the repository at this point in the history