Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in entrypoint lookup for steps by digest #1675

Merged
merged 1 commit into from
Dec 4, 2019

Commits on Dec 3, 2019

  1. Fix bug in entrypoint lookup for steps by digest

    Before this change, any resolved digests would be simply appended to the
    input image name, which would result in invalid duplicate digests when
    the input was specified by digest.
    
    This change uses ref.Context() instead, which omits the digest (or tag),
    and appends the resolved digest to the end of that.
    
    This also slightly refactors entrypoint_lookup_impl.go to make it
    slightly easier to test, and adds a simple unit test for this specific
    error condition.
    
    More tests will be included in future changes.
    imjasonh committed Dec 3, 2019
    Configuration menu
    Copy the full SHA
    d0dfa77 View commit details
    Browse the repository at this point in the history